[UI] - Colocated components in addons#31413
Merged
Merged
Conversation
github-actions
Bot
added
the
hashicorp-contributed-pr
meirish
added
ui
pr/no-changelog
and removed
hashicorp-contributed-pr
|
Build Results: |
|
CI Results: |
meirish
changed the title
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
Bot
added
the
hashicorp-contributed-pr
emoncuso
approved these changes
Aug 2, 2025
|
|
||
| export default Actions.extend({ | ||
| tagName: '' | ||
| tagName: '', |
Collaborator
Author
There was a problem hiding this comment.
😂 those are next on the chopping block
9 tasks
meirish
added a commit
that referenced
this pull request
Aug 12, 2025
* core: run colocated components codemod * kmip: run colocated components codemod * replication: run colocated components codemod * core: remove manual setting of templates with setComponentTemplate * run prettier
9 tasks
meirish
added a commit
that referenced
this pull request
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The initial PR to do colocated component templates only ran the codemod on the main application. This follow up runs it in each of the requisite in-repo addons as well.
Additionally, there were a few components that were Glimmer components that were importing a layout from the old location, and then using
setComponentTemplate. Those were manually updated to just export the backing class as the resolution of templates will now work normally.JIRA ticket
Enterprise tests pass:
TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch. Note that in the CE repo, the latest release branch will look likebackport/x.x.x, but older release branches will bebackport/ent/x.x.x+ent.of a public function, even if that change is in a CE file, double check that
applying the patch for this PR to the ENT repo and running tests doesn't
break any tests. Sometimes ENT only tests rely on public functions in CE
files.
in the PR description, commit message, or branch name.
description. Also, make sure the changelog is in this PR, not in your ENT PR.
PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.