Skip to content

Add main ACME page to docs#2013

Merged
schavis merged 12 commits intomainfrom
stevendpclark_vault-43307_add_acme_page
Mar 23, 2026
Merged

Add main ACME page to docs#2013
schavis merged 12 commits intomainfrom
stevendpclark_vault-43307_add_acme_page

Conversation

@stevendpclark
Copy link
Copy Markdown
Contributor

We had dedicated pages for setting up the other issuance protocols but were missing the ACME page.

@stevendpclark stevendpclark self-assigned this Mar 16, 2026
@stevendpclark stevendpclark requested a review from a team as a code owner March 16, 2026 19:18
@stevendpclark stevendpclark added the Vault Content update for Vault product docs label Mar 16, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2026

Vercel Previews Deployed

Name Status Preview Updated (UTC)
Dev Portal ✅ Ready (Inspect) Visit Preview Mon Mar 23 20:41:44 UTC 2026
Unified Docs API ✅ Ready (Inspect) Visit Preview Mon Mar 23 20:37:26 UTC 2026

@stevendpclark stevendpclark marked this pull request as draft March 16, 2026 19:43
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 16, 2026

Broken Link Checker

No broken links found! 🎉

@stevendpclark stevendpclark marked this pull request as ready for review March 16, 2026 20:20
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/index.mdx Outdated
stevendpclark and others added 3 commits March 20, 2026 11:54
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@stevendpclark stevendpclark requested a review from schavis March 20, 2026 16:32
@stevendpclark
Copy link
Copy Markdown
Contributor Author

stevendpclark commented Mar 20, 2026

@schavis thanks for the initial review, I've applied the suggestions and made some further small tweaks within e3d3028

Copy link
Copy Markdown
Contributor

@schavis schavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm. Just need to fix the floating "For example".

Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Co-authored-by: Sarah Chavis <62406755+schavis@users.noreply.github.com>
@stevendpclark stevendpclark requested a review from schavis March 23, 2026 14:17
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
Fix codeblock indent
Comment thread content/vault/v1.21.x/content/docs/secrets/pki/acme.mdx Outdated
@schavis schavis enabled auto-merge (squash) March 23, 2026 20:21
@schavis schavis merged commit 13fea5c into main Mar 23, 2026
15 checks passed
@schavis schavis deleted the stevendpclark_vault-43307_add_acme_page branch March 23, 2026 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Vault Content update for Vault product docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants