Open
Conversation
This patch fixes the issue that `@:` is lexed as `[At, ConSym ":"]`. Now it is lexed as `[VarSym "@:"]`.
autotaker
commented
Mar 12, 2019
| -- Used in the lexing of type applications | ||
| -- Why is it like this? I don't know exactly but this is how it is in | ||
| -- GHC's parser. | ||
| -- Symbol `:` is added so that `@:` is lexed as `VarSym "@:"`. See Issue #326 |
Author
There was a problem hiding this comment.
GHC's counterpart notFollowedBySymbol does not contain :.
notFollowedBySymbol :: AlexAccPred ExtsBitmap
notFollowedBySymbol _ _ _ (AI _ buf)
= nextCharIsNot buf (`elem` "!#$%&*+./<=>?@\\^|-~")There are two rules that matches for @: in Lexer.x.
-- See Note [Lexing type applications]
<0> {
[^ $idchar \) ] ^
"@"
/ { ifExtension TypeApplicationsBit `alexAndPred` notFollowedBySymbol }
{ token ITtypeApp }
}
and
<0> {
@varsym { varsym }
...
}
Then, alex chooses the rule that consumes the longest prefix. Thus it is recognized as an operator "@:".
When the input stream matches more than one rule, the rule which matches the longest prefix of the input stream wins. If there are still several rules which match an equal number of characters, then the rule which appears earliest in the file wins.
(Cited from 3.2. Syntax of Alex files)
This patch may be ad-hoc. Nonetheless it is correct because isOpSymbol is only used for TypeApplications.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes the issue #326 that
@:is lexed as[At, ConSym ":"].Now it is lexed as
[VarSym "@:"].