Skip to content

chore(deps): bump serial_test from 3.3.1 to 4.0.1 in /codex-rs - #481

Open
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/cargo/codex-rs/serial_test-4.0.1
Open

chore(deps): bump serial_test from 3.3.1 to 4.0.1 in /codex-rs#481
dependabot[bot] wants to merge 2 commits into
mainfrom
dependabot/cargo/codex-rs/serial_test-4.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Aug 4, 2026

Copy link
Copy Markdown
Contributor

Bumps serial_test from 3.3.1 to 4.0.1.

Release notes

Sourced from serial_test's releases.

v4.0.1

As per v4.0.0, but with the root MSRV correctly set to 1.93.1

v4.0.0

What's Changed

New Contributors

Full Changelog: palfrey/serial_test@v3.5.0...v4.0.0

v3.5.0

What's Changed

New Contributors

Full Changelog: palfrey/serial_test@v3.4.0...v3.5.0

v3.4.0

What's Changed

New Contributors

Full Changelog: palfrey/serial_test@v3.3.1...v3.3.2

Commits
  • 383c894 4.0.1
  • 4298adf MSRV is actually 1.93.1
  • f25d56f 4.0.0
  • 7984bdc Merge pull request #160 from palfrey/pre-release-fixes
  • ec74212 Don't need to split build-all-features now
  • 03cd910 Upgrade MSRV to 1.93.1
  • 7cf8563 Add a "finish" CI job that depends on everything
  • d7c4137 Upgrade actix-macros to reduce syn 1.x needs
  • ae268b0 Merge pull request #159 from AudaciousAxiom/refactor/syn-v3
  • 98b2c36 refactor(derive): bump syn to v3
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Bumps [serial_test](https://github.com/palfrey/serial_test) from 3.3.1 to 4.0.1.
- [Release notes](https://github.com/palfrey/serial_test/releases)
- [Commits](palfrey/serial_test@v3.3.1...v4.0.1)

---
updated-dependencies:
- dependency-name: serial_test
  dependency-version: 4.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file rust Pull requests that update rust code labels Aug 4, 2026
@andrei-hasna

Copy link
Copy Markdown
Contributor

[REVIEW] NO_GO — #481 @ 9208dc7 — lens: correctness+security+gates, reviewer unresolved-account001 (1 of 1)

Candidate and source read:

  • git rev-parse HEAD — exit 0; exact head 9208dc7f947564a8e0c8a4b144f7384cabf5c645.
  • git rev-parse origin/main — exit 0; reviewed base 8fb2fd621edee1b9553a0c689d0404271488ae0c.
  • git log --oneline origin/main..HEAD — exit 0; one dependency-bump commit.
  • git diff origin/main...HEAD --stat — exit 0; 2 files, 17 insertions, 22 deletions.
  • Full diffs and surrounding source read for codex-rs/Cargo.toml and codex-rs/Cargo.lock, plus all repository serial_test call sites, the Cargo and Bazel Rust toolchain pins, MODULE.bazel, the Bazel lock recipes, the Bazel workflow lock step, and upstream serial_test 4.0.0/4.0.1 release notes and commit comparison.
  • Compatibility result: all reachable call sites use supported #[serial] forms. serial_test 4.0.1 raises MSRV to 1.93.1 and moves its derive crate to syn 3; this repo pins Cargo Rust 1.97.1 and Bazel Rust 1.95.0. No correctness, security, session-integrity, or user-facing breaking defect found there.

Commands and declared gates:

  • bun install — exit 0; setup only, 521 packages installed, no test counts. This is not a repository gate.
  • This repository declares no typecheck script.
  • This repository declares no test gate: package.json is present and has no test script.
  • No lane-chosen test command was run.
  • gh pr view 481 --repo hasna/codewith --json statusCheckRollup — exit 0; authoritative forge rollup: 34 SUCCESS, 5 FAILURE, 1 CANCELLED, 3 SKIPPED. The rollup exposes check conclusions, not per-check test pass/fail counts.

Forge checks read by name:

  • FAILURE — Bazel test on ubuntu-24.04 for x86_64-unknown-linux-gnu
  • SUCCESS — cla
  • SUCCESS — Check for spelling errors
  • SUCCESS — Blob size policy
  • SUCCESS — cargo-deny
  • SUCCESS — build-test
  • SUCCESS — Build Codewith Linux CLI
  • SUCCESS — Detect changed areas
  • SUCCESS — python-sdk
  • SUCCESS — metadata
  • FAILURE — Bazel test on ubuntu-24.04 for x86_64-unknown-linux-musl
  • SUCCESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 1/4
  • SUCCESS — Format / etc
  • SUCCESS — sdks
  • SUCCESS — Build release x86_64-unknown-linux-gnu
  • SUCCESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 2/4
  • SUCCESS — Build ptrcomp-sandbox x86_64-unknown-linux-gnu
  • SUCCESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 3/4
  • SUCCESS — Build release aarch64-unknown-linux-gnu
  • SUCCESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm shard 4/4
  • SUCCESS — Build ptrcomp-sandbox aarch64-unknown-linux-gnu
  • SUCCESS — Build release x86_64-apple-darwin
  • SUCCESS — Build ptrcomp-sandbox x86_64-apple-darwin
  • SUCCESS — Build release aarch64-apple-darwin
  • SUCCESS — Build ptrcomp-sandbox aarch64-apple-darwin
  • SUCCESS — Build release x86_64-unknown-linux-musl
  • SUCCESS — Build ptrcomp-sandbox x86_64-unknown-linux-musl
  • SUCCESS — Build release aarch64-unknown-linux-musl
  • SUCCESS — Build ptrcomp-sandbox aarch64-unknown-linux-musl
  • SKIPPED — Bazel test on windows-latest for x86_64-pc-windows-gnullvm (native main)
  • SUCCESS — cargo shear
  • SUCCESS — Build ptrcomp-sandbox x86_64-pc-windows-msvc from source
  • SUCCESS — Build ptrcomp-sandbox aarch64-pc-windows-msvc from source
  • FAILURE — Bazel clippy on ubuntu-24.04 for x86_64-unknown-linux-gnu
  • SKIPPED — Argument comment lint package
  • SUCCESS — Bazel clippy on windows-latest for x86_64-pc-windows-gnullvm
  • FAILURE — Verify release build on ubuntu-24.04 for x86_64-unknown-linux-gnu
  • CANCELLED — Argument comment lint - Linux
  • SUCCESS — Verify release build on windows-latest for x86_64-pc-windows-gnullvm
  • SUCCESS — Argument comment lint - Windows
  • FAILURE — CI results (required)
  • SUCCESS — Bazel test on windows-latest for x86_64-pc-windows-gnullvm
  • SKIPPED — [code]smith

Blocking P0/P1 findings:

  • P1 required build gate: codex-rs/Cargo.toml and codex-rs/Cargo.lock change dependency resolution, but MODULE.bazel.lock was not refreshed. The repo's documented dependency workflow requires just bazel-lock-update; the authoritative GNU/Linux Bazel job reproduced the defect at its Check MODULE.bazel.lock is up to date step, then skipped bazel test //.... Remedy: refresh and commit MODULE.bazel.lock, then rerun the forge checks. The other red Linux jobs and the cancelled Linux argument-lint job also require a green rerun before merge, but their available step metadata does not establish an additional candidate-code defect; their Windows counterparts passed.

Non-blocking follow-ups:

  • None. The dependency is test-only, the supported macro forms are unchanged at the repository call sites, and the declared Rust toolchains exceed the new MSRV.

Agent: unresolved-account001
@andrei-hasna

Copy link
Copy Markdown
Contributor

[REVIEW-FIX] #481 — resolved the named Bazel lock blocker

Pushed commit 9eceb55248a81838dc7913421f0b5150a548c53d to the PR branch.

  • just bazel-lock-update — exit 127 because just is not installed in this lane.
  • Invoked the recipe's underlying bazel mod deps --lockfile_mode=update directly — exit 0.
  • Generated only MODULE.bazel.lock: 3 insertions, 4 deletions.
  • Focused remediation check ./scripts/check-module-bazel-lock.sh — exit 0; no test counts (lock-alignment check, not the package test gate).
  • Staged-file gitleaks scan with full redaction — exit 0; no leaks.
  • Commit-range gitleaks scan before push — exit 0; 1 commit scanned, no leaks.
  • Commit trailer is exactly Agent: unresolved-account001; no Co-Authored-By line.

The prior NO_GO names SHA 9208dc7f947564a8e0c8a4b144f7384cabf5c645 and is now stale. The new head still needs its authoritative forge checks and focused re-review before any GO or merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file rust Pull requests that update rust code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant