chore(release): 1.4.0 + harden the no-cloud boundary guard - #334
Merged
Conversation
added 2 commits
July 27, 2026 00:10
Minor rather than patch: this removes CLI and MCP surface. The `connectors cloud` command group and the cloud MCP tools are gone along with the @hasna/cloud dependency. Matches the repo's existing convention of taking a minor for removals (0.2.9 -> 0.3.0 removed the MCP `.describe()` surface). Rolls the pending connect-x OAuth test entry into the release section. Refs: todos be07a270
Adversarial review found the previous guard far weaker than its own commit message claimed: 12 of 14 bypass attempts passed clean. It only caught a `from "..."` specifier, in six extensions, directly under `src/`, and it skipped any directory basenamed `bin` or `dist` at any depth. The gap that mattered most: `connectors/` and `dashboard/dist/` are both published via package.json `files`, so a vendored connector could have reintroduced the package and shipped it to every machine in the fleet without tripping anything. - Scan roots now come from package.json `files`, plus `src`, `scripts` and `sdk`. Driving this off `files` means a newly shipped directory is covered automatically instead of silently escaping the guard. - SKIP_DIRS is now only `node_modules` and `.git`, so `src/bin/` and `src/dist/` are no longer holes. - Added `mts`/`cts` to the scanned extensions. - The specifier pattern now also matches a bare `import "pkg"` with no `from`. - Manifest check covers every field that can pull a package into an install (bundle/bundled/overrides/resolutions/trustedDependencies alongside the four it already had), and now runs against every package.json in the shipped tree, not just the root one. - Added a lockfile assertion. Verified by replanting all 14 bypasses: every one is now caught. The scan reads ~14k shipped source files and ~1.2k manifests in about 3.7s. Refs: todos be07a270
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #333. That PR was merged while I was still pushing to the branch, so
maincarries the cloud removal but not these two commits. Without themmain'spackage.jsonstill says1.3.46, which is already on npm — publishing would conflict.1.
chore(release): 1.4.0Minor rather than patch, because #333 removed public surface: the whole
connectors cloudcommand group and 4 cloud MCP tools. This matches the repo's existing convention of taking a minor for removals (0.2.9 -> 0.3.0removed the MCP.describe()surface). Adds the missing## [1.4.0]CHANGELOG section with a### Removedentry, so anyone scriptingconnectors cloud sync pushgets a release note for the break instead of a silent failure.2.
test(no-cloud): widen the boundary guardAdversarial review found the guard shipped in #333 much weaker than its own commit message claimed — 12 of 14 bypass attempts passed clean. It only matched a
from "..."specifier, in six extensions, directly undersrc/, and skipped any directory basenamedbinordistat any depth.The gap that actually mattered:
connectors/anddashboard/dist/are both published viapackage.jsonfiles. A vendored connector could have reintroduced@hasna/cloudand shipped it to every machine in the fleet without tripping anything.package.jsonfiles, plussrc,scripts,sdk. Driving it offfilesmeans a newly shipped directory is covered automatically rather than silently escaping the guard.SKIP_DIRSreduced tonode_modulesand.git, sosrc/bin/andsrc/dist/are no longer holes.mts/cts.import "pkg"with nofrom.bundleDependencies,bundledDependencies,overrides,resolutions,trustedDependenciesalongside the original four) and runs over everypackage.jsonin the shipped tree, not just the root.Re-planting every bypass: 20 caught, 0 bypassed. Scan covers ~14k shipped source files and ~1.2k manifests in ~3.7s.
Verification
Refs: todos
be07a270Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.