Skip to content

test(send): pin that the authoritative read-back carries no degradation marker #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrei-hasna merged 1 commit into from
Aug 5, 2026
Merged

test(send): pin that the authoritative read-back carries no degradation marker #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/lib/store/api-store.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,13 @@ describe("ApiStore.sendMessage wire body", () => {
});

expect(message).toMatchObject({ id: 649560, uuid: exactUuid, channel: "git-publishing" });
// The by-uuid read-back is the AUTHORITATIVE path, so it must carry no
// degradation marker. `toMatchObject` above is a subset match and would
// silently accept a stray one, which would corrupt the exact signal the
// field exists to provide — and `sendMessage` has two authoritative returns
// (create-echo and this read-back), of which the other one was already
// covered and this one was not.
expect((message as unknown as { write_confirmation?: unknown }).write_confirmation).toBeUndefined();
});

// ── regression: rc=1 on a write that fully succeeded (todos d8f3f963) ────────
Expand Down
Loading