Skip to content

fix: add knowledge contract release conformance #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrei-hasna merged 1 commit into from
Aug 1, 2026
Merged

fix: add knowledge contract release conformance #63

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bin/knowledge-mcp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15053,8 +15053,9 @@ var package_default = {
"migrate:cloud": "bun scripts/apply-cloud-migrations.mjs",
serve: "bun src/serve-entry.ts",
"verify:generated": "bun scripts/verify-generated-artifacts.mjs",
"contracts:conformance": "contracts conformance fixtures",
build: "rm -rf dist && bun build --target=bun --outfile=bin/knowledge.js --minify --external pg --external @hasna/machines --external @hasna/machines/consumer --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek src/cli.ts && bun build --target=bun --outfile=bin/knowledge-mcp.js --external pg --external @hasna/machines --external @hasna/machines/consumer --external @modelcontextprotocol/sdk --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek src/mcp.js && bun build --target=bun --outfile=bin/knowledge-serve.js --external pg --external @hasna/machines --external @hasna/machines/consumer --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek src/serve-entry.ts && bun build ./src/index.ts ./src/storage.ts ./src/serve.ts --outdir ./dist --target bun --external pg --external @hasna/machines --external @hasna/machines/consumer --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek && bun scripts/strip-generated-trailing-whitespace.mjs && bunx tsc -p tsconfig.build.json",
prepublishOnly: "bun run build && node scripts/validate-public-package.mjs"
prepublishOnly: "bun run contracts:conformance && contracts no-cloud-scan . && bun run build && node scripts/validate-public-package.mjs"
},
keywords: [
"knowledge",
Expand Down
2 changes: 1 addition & 1 deletion bin/knowledge.js
View file
Open in desktop

Large diffs are not rendered by default.

91 changes: 91 additions & 0 deletions fixtures/project-panel.invalid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,91 @@
{
"schema": "hasna.project_panel.v1",
"id": "knowledge_panel_open-knowledge",
"createdAt": "2026-08-01T09:00:00.000Z",
"projectId": "open-knowledge",
"provider": {
"kind": "knowledge",
"id": "knowledge_open-knowledge",
"name": "Knowledge",
"sourcePackage": "@hasna/knowledge",
"externalId": "project://open-knowledge"
},
"kind": "knowledge",
"title": "Knowledge",
"summary": "1 active note, 1 source, and 3 indexed chunks.",
"state": "ready",
"generatedAt": "2026-08-01T09:00:00.000Z",
"freshness": "fresh",
"metrics": [
{
"id": "active_items",
"label": "Active notes",
"value": 1,
"status": "good"
},
{
"id": "active_items",
"label": "Duplicate active notes metric",
"value": 1,
"status": "good"
}
],
"items": [
{
"id": "item_contract-boundaries",
"title": "Contract boundaries",
"summary": "Shared project-panel payloads are parsed at the package boundary.",
"status": "active",
"priority": "medium",
"resourceRefs": [
{
"kind": "knowledge",
"id": "contract-boundaries",
"name": "Contract boundaries",
"uri": "knowledge://item/contract-boundaries",
"externalId": "contract-boundaries",
"sourcePackage": "@hasna/knowledge",
"tags": [
"contracts"
]
}
],
"evidenceRefs": []
}
],
"actions": [
{
"kind": "action",
"id": "knowledge:inventory",
"name": "Inspect knowledge inventory",
"externalId": "knowledge:inventory",
"sourcePackage": "@hasna/knowledge",
"tags": []
}
],
"resourceRefs": [
{
"kind": "project",
"id": "open-knowledge",
"name": "open-knowledge",
"uri": "project://open-knowledge",
"externalId": "open-knowledge",
"sourcePackage": "@hasna/knowledge",
"tags": []
}
],
"renderFragment": {
"renderer": "json_render",
"title": "Knowledge",
"spec": {
"component": "project.knowledge.summary",
"metrics": [
"active_items"
]
}
},
"metadata": {
"scope": "project",
"home": "project://open-knowledge"
}
}
85 changes: 85 additions & 0 deletions fixtures/project-panel.valid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
{
"schema": "hasna.project_panel.v1",
"id": "knowledge_panel_open-knowledge",
"createdAt": "2026-08-01T09:00:00.000Z",
"projectId": "open-knowledge",
"provider": {
"kind": "knowledge",
"id": "knowledge_open-knowledge",
"name": "Knowledge",
"sourcePackage": "@hasna/knowledge",
"externalId": "project://open-knowledge"
},
"kind": "knowledge",
"title": "Knowledge",
"summary": "1 active note, 1 source, and 3 indexed chunks.",
"state": "ready",
"generatedAt": "2026-08-01T09:00:00.000Z",
"freshness": "fresh",
"metrics": [
{
"id": "active_items",
"label": "Active notes",
"value": 1,
"status": "good"
}
],
"items": [
{
"id": "item_contract-boundaries",
"title": "Contract boundaries",
"summary": "Shared project-panel payloads are parsed at the package boundary.",
"status": "active",
"priority": "medium",
"resourceRefs": [
{
"kind": "knowledge",
"id": "contract-boundaries",
"name": "Contract boundaries",
"uri": "knowledge://item/contract-boundaries",
"externalId": "contract-boundaries",
"sourcePackage": "@hasna/knowledge",
"tags": [
"contracts"
]
}
],
"evidenceRefs": []
}
],
"actions": [
{
"kind": "action",
"id": "knowledge:inventory",
"name": "Inspect knowledge inventory",
"externalId": "knowledge:inventory",
"sourcePackage": "@hasna/knowledge",
"tags": []
}
],
"resourceRefs": [
{
"kind": "project",
"id": "open-knowledge",
"name": "open-knowledge",
"uri": "project://open-knowledge",
"externalId": "open-knowledge",
"sourcePackage": "@hasna/knowledge",
"tags": []
}
],
"renderFragment": {
"renderer": "json_render",
"title": "Knowledge",
"spec": {
"component": "project.knowledge.summary",
"metrics": [
"active_items"
]
}
},
"metadata": {
"scope": "project",
"home": "project://open-knowledge"
}
}
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@
"migrate:cloud": "bun scripts/apply-cloud-migrations.mjs",
"serve": "bun src/serve-entry.ts",
"verify:generated": "bun scripts/verify-generated-artifacts.mjs",
"contracts:conformance": "contracts conformance fixtures",
"build": "rm -rf dist && bun build --target=bun --outfile=bin/knowledge.js --minify --external pg --external @hasna/machines --external @hasna/machines/consumer --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek src/cli.ts && bun build --target=bun --outfile=bin/knowledge-mcp.js --external pg --external @hasna/machines --external @hasna/machines/consumer --external @modelcontextprotocol/sdk --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek src/mcp.js && bun build --target=bun --outfile=bin/knowledge-serve.js --external pg --external @hasna/machines --external @hasna/machines/consumer --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek src/serve-entry.ts && bun build ./src/index.ts ./src/storage.ts ./src/serve.ts --outdir ./dist --target bun --external pg --external @hasna/machines --external @hasna/machines/consumer --external @aws-sdk/client-s3 --external @aws-sdk/credential-providers --external ai --external @ai-sdk/openai --external @ai-sdk/anthropic --external @ai-sdk/deepseek && bun scripts/strip-generated-trailing-whitespace.mjs && bunx tsc -p tsconfig.build.json",
"prepublishOnly": "bun run build && node scripts/validate-public-package.mjs"
"prepublishOnly": "bun run contracts:conformance && contracts no-cloud-scan . && bun run build && node scripts/validate-public-package.mjs"
},
"keywords": [
"knowledge",
Expand Down
Loading