fix(repos): enforce managed identity on direct lookup - #70
Merged
Conversation
Agent: unresolved-account004
andrei-hasna
force-pushed
the
fix/67-iapp-todos-identity
branch
from
August 7, 2026 15:59
f7d4113 to
c124509
Compare
Contributor
Author
|
[REVIEW] GO — #70 @ c124509 — lens: correctness+security+gates, reviewer unresolved-account004 (1 of 1) Independent focused verification found no blocking P0/P1 defects. Read:
Executor gates on the patch-identical candidate:
Independent focused checks:
The reviewer did not count its own queued Blocking P0/P1 findings: none. Non-blocking follow-up: add a persistent direct unit regression for the numeric-ID mismatch route. The committed worktree regression covers exact-path refusal; the numeric-ID route was verified by the focused runtime probe. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #68 after its original candidate merged before the independent review finding was posted.
Blocking defect fixed
A caller could pass a mismatched managed checkout path directly to
repos worktree add/addWorktree().getRepo(path)returned the row before applying the new managed-identity invariant, so the worktree plane created a branch and worktree from the wrong repository even whilerepos repo <same-path>correctly refused.Fix
REPO_IDENTITY_MISMATCHat the worktree boundaryEvidence
repos repo <path>exit 1, thenaddWorktree({ repo: path })returnedCREATEDREFUSED, codeREPO_IDENTITY_MISMATCH, empty worktree root, empty branch result, zero leasesbun run typecheck: exit 0bun run test: 803 pass, 0 fail, 3571 assertions across 52 filesgit diff --check: exit 0Commit:
f7d4113361c5bb77241bf1f90fffe3cdf39a54d5Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.