ci: hasna/terminal has no GitHub Actions workflow — add a test+typecheck - #4
ci: hasna/terminal has no GitHub Actions workflow — add a test+typecheck#4hasna-identity[bot] wants to merge 1 commit into
Conversation
CI: hasna/terminal has no GitHub Actions workflow — add a test+typecheck gate on pull_request X-Factory-Run: run_32384bac91f7 X-Factory-Task: bb193c89-7c7b-42b7-a699-2de787f116f3
|
CI note (ops drain): the new workflow ran and caught a real env-dependent test — 'getTerminalDir default > returns a path ending with terminal' passes on dev hosts and in factory host-side verify but fails on the GitHub runner (236/237 pass otherwise). The gate is doing its job; the test needs to be made hermetic (derive expectation from the same env resolution the code uses) rather than weakening the workflow. |
|
Closing. The workflow in this PR is correct — the repo is not ready for it. Verified on run 30521234557 (job 90801878582). The job failed after 8 seconds on one test: (fail) getTerminalDir default > returns a path ending with terminal This is a real repo defect that CI correctly surfaced, not CI flake. Bun runs every test file in one process, so this only appears when the whole suite runs together — exactly what CI does and exactly what nobody does locally. That is the same disease Merging this would have installed a gate that is red on Tracked as todos OPE103-00004 with the exact remedy: give that describe its own Also note this PR's workflow triggers on |
Objective
CI: hasna/terminal has no GitHub Actions workflow — add a test+typecheck gate on pull_request
Verification
Run
run_32384bac91f7· backendcodewith· taskbb193c89-7c7b-42b7-a699-2de787f116f3🏭 Generated by @hasnaxyz/factory
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.