Open
Conversation
Just starting to carry tests over and try to make sense of them. Found some strange behaviours, and have left myself a couple little markers for the PR to ask for further clarification.
More work on porting the test suite across to Tasty. Most of these are nice, straightforward unit tests, though I definitely think we should write some property tests soon. There are some really nice candidates in this library.
All the tests have been migrated. They're _all_ tests for the parser, so we ought to try to add some more tests for the rest.
jkachmar
force-pushed
the
jkachmar_tom/tasty
branch
from
d8c0611 to
7cf50f0
Compare
Contributor
Author
|
This is basically done; let me know if you’d like to pair on anything to finish it up (in which case I am more than willing to find some free time to do so in the interests of polishing up some OSS work). |
|
@jkachmar Don't worry at all! I'll get to this sooner or later :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.