Skip to content

gRPC: add some missing payment methods#2030

Open
fxrstor wants to merge 2 commits intohaveno-dex:masterfrom
fxrstor:master
Open

gRPC: add some missing payment methods#2030
fxrstor wants to merge 2 commits intohaveno-dex:masterfrom
fxrstor:master

Conversation

@fxrstor
Copy link
Copy Markdown
Contributor

@fxrstor fxrstor commented Oct 27, 2025

As the title suggests, this PR adds implementation of some payment methods which are previously "Not Implemented" to gRPC.
The following have been added:

  1. Western Union
  2. National Bank
  3. Same Bank
  4. Specific Banks
  5. NEFT
  6. RTGS
  7. IMPS
  8. UPI
  9. PAYTM
  10. Domestic Wire Transfer
  11. Japan Bank
  12. Prompt Pay
  13. Verse
  14. Hal Cash
  15. Money Beam
  16. Pop Money
  17. Cash Deposit
  18. Perfect Money
  19. Advanced Cash
  20. Paysera
  21. Nequi
  22. Bizum
  23. Pix
  24. Capitual
  25. Celpay
  26. Monese
  27. Satispay
  28. Tikke

Developer notes: could you please pay extra attention to getEmptyFormField and see if the label configuration is right?

@fxrstor
Copy link
Copy Markdown
Contributor Author

fxrstor commented Nov 10, 2025

@woodser Please review this PR :)
I've tested this PR from my side locally and the API works well (CreatePaymentAccount and GetPaymentAccounts tested).

edit: I heard that there is a need for some mass changes in grpc, can we discuss them via email (I have emailed you already)?

@atsamd21
Copy link
Copy Markdown
Contributor

atsamd21 commented Jan 8, 2026

I'm currently reviewing this, what code are you using to test CreatePaymentAccount?

@fxrstor
Copy link
Copy Markdown
Contributor Author

fxrstor commented Jan 10, 2026

I'm currently reviewing this, what code are you using to test CreatePaymentAccount?

I just manually tested it with grpcurl. I'm pretty sure you could test this with haveno-ts but that would require some updates in the protobuf files.

@atsamd21
Copy link
Copy Markdown
Contributor

I'm currently reviewing this, what code are you using to test CreatePaymentAccount?

I just manually tested it with grpcurl. I'm pretty sure you could test this with haveno-ts but that would require some updates in the protobuf files.

I'm having some issues creating accounts, it seems like some of the forms are incomplete.

Western union:

  • missing COUNTRY field
  • city field has wrong label "country"

National bank:

  • missing TRADE_CURRENCIES field
  • BRANCH_ID missing label
  • BANK_ID missing label

I will continue reviewing but could you please check the rest as well to make sure there aren't any missing fields etc

@fxrstor
Copy link
Copy Markdown
Contributor Author

fxrstor commented Jan 10, 2026

I'm currently reviewing this, what code are you using to test CreatePaymentAccount?

I just manually tested it with grpcurl. I'm pretty sure you could test this with haveno-ts but that would require some updates in the protobuf files.

I'm having some issues creating accounts, it seems like some of the forms are incomplete.

Western union:

* missing COUNTRY field

* city field has wrong label "country"

National bank:

* missing TRADE_CURRENCIES field

* BRANCH_ID missing label

* BANK_ID missing label

I will continue reviewing but could you please check the rest as well to make sure there aren't any missing fields etc

Will do rn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants