gRPC: add some missing payment methods#2030
gRPC: add some missing payment methods#2030fxrstor wants to merge 2 commits intohaveno-dex:masterfrom
Conversation
|
@woodser Please review this PR :) edit: I heard that there is a need for some mass changes in grpc, can we discuss them via email (I have emailed you already)? |
|
I'm currently reviewing this, what code are you using to test CreatePaymentAccount? |
I just manually tested it with grpcurl. I'm pretty sure you could test this with |
I'm having some issues creating accounts, it seems like some of the forms are incomplete. Western union:
National bank:
I will continue reviewing but could you please check the rest as well to make sure there aren't any missing fields etc |
Will do rn |
As the title suggests, this PR adds implementation of some payment methods which are previously "Not Implemented" to gRPC.
The following have been added:
Developer notes: could you please pay extra attention to
getEmptyFormFieldand see if the label configuration is right?