chore: update to nightly-2021-09-22, fix clippy#115
Merged
Conversation
This just updates Rust to the latest nightly, and fixes a new Clippy lint on that nightly.
hawkw
added a commit
that referenced
this pull request
Sep 25, 2021
This reverts commit bbf73a7. It turns out some kind of change in linker behavior renders our cool test stuff hilariously broken: https://github.com/hawkw/mycelium/runs/3709572933?check_suite_focus=true Perhaps @mystor knows about what's going on here. For now, though, I'm just gonna revert the nightly bump so that we can like, build mycelium again lol.
Collaborator
|
As we discussed on Discord, this is likely due to some changes to how rustc handles the It may be necessary for rust to expose some way to use the old |
hawkw
added a commit
that referenced
this pull request
Sep 26, 2021
This just updates Rust to the latest nightly, and fixes a new Clippy lint on that nightly.
hawkw
added a commit
that referenced
this pull request
Sep 27, 2021
* chore: update to nightly-2021-09-22, fix clippy (#115) This just updates Rust to the latest nightly, and fixes a new Clippy lint on that nightly. * chore(x86_64): add `-z nostart-stop-gc` to linker args when linking with `rust-lld` on recent nightlies, `__start` and `__stop` labels are now gc'd by default. this breaks the linker hax we use for tests. this argument makes `lld` stop doing that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just updates Rust to the latest nightly, and fixes a new Clippy
lint on that nightly.