Skip to content

Asyncio Connection Refactoring#829

Merged
yuce merged 6 commits into
hazelcast:masterfrom
yuce:conn-debug
Jun 25, 2026
Merged

Asyncio Connection Refactoring#829
yuce merged 6 commits into
hazelcast:masterfrom
yuce:conn-debug

Conversation

@yuce

@yuce yuce commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Simplified the asyncio connection workflow to fix connection issues.

Previously we created a socket, connect it to the server and add it to the asyncio loop.
With the changes in this PR, we use asyncio.loop.create_connection directly, and delegate socket creation to asyncio.
That makes the connection logic simpler, and more robust.

@codecov-commenter

codecov-commenter commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.23810% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.20%. Comparing base (aece404) to head (2a12bd3).

Files with missing lines Patch % Lines
hazelcast/internal/asyncio_reactor.py 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #829      +/-   ##
==========================================
+ Coverage   94.13%   94.20%   +0.07%     
==========================================
  Files         413      413              
  Lines       27703    27662      -41     
==========================================
- Hits        26078    26059      -19     
+ Misses       1625     1603      -22     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuce yuce changed the title [DONT MERGE] Connection refactor Asyncio Connection Refactoring Jun 25, 2026
@yuce yuce requested a review from dmitriyrazboev June 25, 2026 03:51
@yuce yuce merged commit 10f73ba into hazelcast:master Jun 25, 2026
11 checks passed
@yuce yuce deleted the conn-debug branch June 25, 2026 07:59
@yuce yuce added this to the 5.7.0 milestone Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants