Fix file sizes#64
Merged
Merged
Conversation
In hazelcast#56, it was discovered the pipeline was using wrong filesizes (`MiB` vs `MB`). Although that updated _future_ files, that left older files stuck. I've gone through and updated to be consistent, based on logic _like_: ``` curl -sI https://repository.hazelcast.com/download/management-center/hazelcast-management-center-5.11.0.zip | awk '/^[Cc]ontent-[Ll]ength:/ {print $2}' | tr -d '\r' printf '%s\n' 326254801 | awk '{ printf "%.1f MB\n", $1 / 1000000 }' ``` For platform, I've used whole-sizes, for MC, 1 decimal place to be consistent with existing format.
JackPGreen
force-pushed
the
fix-file-sizes
branch
from
fd39a7f to
1f7dfd4
Compare
nishaatr
approved these changes
May 18, 2026
nishaatr
left a comment
nishaatr
left a comment
Contributor
There was a problem hiding this comment.
It will interesting to see if website actually takes these new values.
Nonetheless, best to fix and make it consistent
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #56, it was discovered the pipeline was using wrong filesizes (
MiBvsMB).Although that updated future files, that left older files stuck.
I've gone through and updated to be consistent, based on logic like:
For platform, I've used whole-sizes, for MC, 1 decimal place to be consistent with existing format.
I've left the rest as parsing disparate formats is too complex for a throwaway activity.