Update rel-scripts to use pre-prod artifacts for file-size calculations [DI-794]#76
Update rel-scripts to use pre-prod artifacts for file-size calculations [DI-794]#76JackPGreen wants to merge 2 commits into
rel-scripts to use pre-prod artifacts for file-size calculations [DI-794]#76Conversation
|
failed btw https://github.com/JackPGreen/rel-scripts/actions/runs/28024048931/job/82947277976
simply build it and check preprod urls are ok? |
I know it failed - because there are no preprod artifacts.
2 hours later... |
| assert downloads.slim_zip.url == "https://example.com/foo-slim.zip" | ||
| assert downloads.full_tar.url == "https://example.com/foo.tar.gz" | ||
| assert downloads.slim_tar.url == "https://example.com/foo-slim.tar.gz" | ||
| assert downloads.full_zip.live_url == "https://example.com/foo.zip" |
There was a problem hiding this comment.
live_url - confusing as we have live or sandbox (preprod could be from either)
may be target_url or just url
There was a problem hiding this comment.
Good point. public_url?
2 participants
When running
package.yml, we create a staged PR which includes links to the downloads and their sizes.This is a problem, as the final downloads shouldn't exist until the
promotestage. Hence we need to resolve the sizes based on the pre-prod location, but publish references to the live URL.Added pre-prod awareness, now queries both sources when trying to determine the download size.
An example execution is here, but I'm unable to properly test as there are no artefacts in the preprod repos(s) to test against. But you can see it querying the preprod repo for the right file (...if it existed...).
Fixes: DI-794