prometheus: Fix invalid cpuQuery and memoryQuery#235
Draft
adwait-godbole wants to merge 1 commit intoheadlamp-k8s:mainfrom
Draft
prometheus: Fix invalid cpuQuery and memoryQuery#235adwait-godbole wants to merge 1 commit intoheadlamp-k8s:mainfrom
cpuQuery and memoryQuery#235adwait-godbole wants to merge 1 commit intoheadlamp-k8s:mainfrom
Conversation
Signed-off-by: Adwait Godbole <adwaitngodbole@gmail.com>
Contributor
|
I remember that the container!='' was added a while ago as a fix for doubled values, could you confirm that we can get rid of it without reintroducing the doubling bug? |
Contributor
|
@yolossn @adwait-godbole please see question above? |
Contributor
|
@illume It is blocked since we couldn't find a proper solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #234
cc @yolossn