ai-assistant: Add ability to run mcp server from ai-assistant plugin by ashu8912 · Pull Request #385 · headlamp-k8s/plugins

ashu8912 · 2025-09-08T17:33:24Z

No description provided.

illume

It's important to do these standard things for PRs to speed reviews along:

PR description
screenshots or video
steps to test each fix or piece of functionality
link to the related issue
If there are no tests at all, please justify this. Note that it will slow reviews down, and slow down future changes
Document fields and functions. This speeds up the review, and helps speed up further changes.
git commit messages with context of the modules changed in subject, AND a "why" in the git commit body unless it's covered in the git message subject.

ai-assistant: MCPSettings: Add MCP settings UI and Electron config API

- Add components/settings/MCPSettings.tsx: UI for configuring MCP servers (add/remove/toggle/edit),
  uses window.desktopApi.mcp.getConfig/updateConfig when running in Electron, falls back to pluginStore.
- Extend ElectronMCPApi typings with getConfig and updateConfig for config persistence.
- Provide default server when enabling MCP with no servers, and a "Test MCP Connection" action.

Notes:
- Argument parsing is space-based (no quote handling).
- Ensure native side exposes getTools (used by the test action) and that updateConfig triggers any required client restart.

Copilot

Pull Request Overview

This PR adds comprehensive MCP (Model Context Protocol) integration to the AI assistant, enabling connection to external tools and services. It introduces tool approval workflows, intelligent argument processing, and enhanced tool management capabilities.

Added MCP server configuration and management in Electron environments
Implemented tool approval dialogs with inline confirmation UI
Created intelligent argument processing using AI for MCP tools
Added tool orchestration for multi-tool execution

Reviewed Changes

Copilot reviewed 40 out of 42 changed files in this pull request and generated 13 comments.

Show a summary per file

File	Description
ai-assistant/src/utils/ToolConfigManager.ts	Added source tracking ('built-in' vs 'mcp'), MCP tool integration functions, and tool state initialization
ai-assistant/src/utils/ToolApprovalManager.ts	New approval manager for tool execution with session-based auto-approval
ai-assistant/src/utils/InlineToolApprovalManager.ts	Inline tool approval with user context extraction for intelligent argument processing
ai-assistant/src/langchain/tools/ToolManager.ts	Enhanced with MCP tool support, argument mapping, and formatter integration
ai-assistant/src/langchain/tools/ToolOrchestrator.ts	New orchestrator for analyzing and coordinating multi-tool execution
ai-assistant/src/langchain/formatters/MCPOutputFormatter.ts	AI-powered formatter for MCP tool output with markdown support
ai-assistant/src/langchain/LangChainManager.ts	Major updates for tool orchestration, inline approval, and argument enhancement
ai-assistant/src/components/mcpOutput/MCPOutputDisplay.tsx	Rich UI component for displaying formatted MCP tool results
ai-assistant/src/components/mcpOutput/MCPArgumentProcessor.ts	Intelligent argument processing with schema validation
ai-assistant/src/components/settings/MCPSettings.tsx	MCP server configuration UI with enable/disable controls
ai-assistant/src/components/common/InlineToolConfirmation.tsx	Inline tool confirmation component (exported via index)
ai-assistant/src/types/electron.d.ts	TypeScript definitions for Electron MCP API
ai-assistant/src/hooks/useClusterChangeNotifier.ts	Hook for monitoring cluster changes and notifying MCP servers

Files not reviewed (1)

ai-assistant/package-lock.json: Language not supported

Comments suppressed due to low confidence (2)

ai-assistant/src/langchain/tools/ToolManager.ts:226

This statement is unreachable.
ai-assistant/src/langchain/tools/ToolManager.ts:258
This statement is unreachable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T10:14:01Z

ai-assistant/src/langchain/tools/ToolManager.ts

+          return this.filterMCPArguments(inputValue, inputSchema);
+          return this.filterMCPArguments(inputValue, inputSchema);


Duplicate return statement on lines 225-226. The second return is unreachable and should be removed.

Copilot · 2025-11-03T10:14:01Z

ai-assistant/src/langchain/tools/ToolManager.ts

+        return inputValue;
+        return inputValue;


Duplicate return statement on lines 257-258. The second return is unreachable and should be removed.

Copilot · 2025-11-03T10:14:01Z

ai-assistant/src/components/settings/MCPServerEditor.tsx

+import {
+  Alert,
+  Box,
+  Button,
+  DialogActions,
+  DialogContent,
+  DialogTitle,
+  FormControlLabel,
+  IconButton,
+  Paper,
+  Switch,
+  TextField,
+  Typography,
+} from '@mui/material';


Unused import Paper.

Copilot · 2025-11-03T10:14:02Z

ai-assistant/src/components/settings/MCPServerFormDialog.tsx

+import {
+  Alert,
+  Box,
+  Button,
+  Chip,
+  DialogActions,
+  DialogContent,
+  DialogTitle,
+  FormControlLabel,
+  IconButton,
+  Paper,
+  Switch,
+  Table,
+  TableBody,
+  TableCell,
+  TableContainer,
+  TableHead,
+  TableRow,
+  TextField,
+  Tooltip,
+  Typography,
+} from '@mui/material';


Unused import Chip.

Copilot · 2025-11-03T10:14:02Z

ai-assistant/src/langchain/formatters/MCPOutputFormatter.ts

+  ): FormattedMCPOutput {
+    // Try to detect if it's JSON
+    let data: any;
+    let type: FormattedMCPOutput['type'] = 'text';


The initial value of type is unused, since it is always overwritten.

Suggested change

let type: FormattedMCPOutput['type'] = 'text';

let type: FormattedMCPOutput['type'];

Copilot · 2025-11-03T10:14:03Z

ai-assistant/src/components/common/InlineToolConfirmation.tsx

+              cursor: isActionInProgress ? 'not-allowed' : 'pointer',
+            }}
+          >
+            {isDenying ? 'Denying...' : 'Deny'}


This use of variable 'isDenying' always evaluates to false.

Copilot · 2025-11-03T10:14:04Z

ai-assistant/src/components/common/InlineToolConfirmation.tsx

+            size="small"
+            onClick={handleApprove}
+            startIcon={
+              isApproving ? (


This use of variable 'isApproving' always evaluates to false.

Copilot · 2025-11-03T10:14:04Z

ai-assistant/src/components/common/InlineToolConfirmation.tsx

+            }
+            color="primary"
+            sx={{
+              opacity: isApproving ? 0.7 : 1,


This use of variable 'isApproving' always evaluates to false.

Copilot · 2025-11-03T10:14:04Z

ai-assistant/src/components/common/InlineToolConfirmation.tsx

+              cursor: isActionInProgress ? 'not-allowed' : 'pointer',
+            }}
+          >
+            {isApproving


This use of variable 'isApproving' always evaluates to false.

Copilot · 2025-11-03T10:14:05Z

ai-assistant/src/langchain/tools/ToolManager.ts

+    }
+
+    // First, check if args is properly structured for the schema
+    if (args && typeof args === 'object') {


This use of variable 'args' always evaluates to true.

illume · 2025-11-04T12:43:54Z

I'm working on this.

illume · 2025-11-07T16:06:33Z

Wtih Azure OpenAI provider gpt4 it's having issues.
With this plugin and headlamp branch mcp-electron 0b95d6d9d38445456655080a042badc3a698689c

With ai-assistant installed from Plugin Catalog it's working.

https://mgns-eastus2.openai.azure.com/openai/deployments/gpt-4/chat/completions?api-version=2024-12…
Request Method: POST

Status Code: 400 Bad Request
{
   "error": {
       "message": "'Make requests to the Kubernetes API server to fetch, create, update or delete resources.\n\nRESOURCE UPDATE GUIDELINES:\n- For UPDATE/MODIFY/CHANGE operations: Use PUT method with ONLY the specific fields to change\n- Provide patch objects that will be merged with existing resources\n- Use null values to remove fields (e.g., {"spec": {"livenessProbe": null}})\n- The system automatically merges patches with current resources before making PUT requests\n\nLOG HANDLING FOR MULTI-CONTAINER PODS:\n- When a user asks for logs from a pod, ALWAYS first check the pod specification to determine the number of containers\n- If the pod has only one container, directly fetch logs: kubernetes_api_request(url="/api/v1/namespaces/default/pods/pod-name/log", method="GET")\n- If the pod has multiple containers, you MUST ask the user which container they want logs from\n- List the available container names and ask the user to specify\n- Once the user specifies a container, fetch logs with the container parameter: kubernetes_api_request(url="/api/v1/namespaces/default/pods/pod-name/log?container=container-name", method="GET")\n- NEVER attempt to fetch logs from a multi-container pod without specifying the container name\n- Examples of user requests that specify containers:\n - "get logs from pod-name container nginx" → kubernetes_api_request(url="/api/v1/namespaces/default/pods/pod-name/log?container=nginx", method="GET")\n - "show logs for container sidecar in pod-name" → kubernetes_api_request(url="/api/v1/namespaces/default/pods/pod-name/log?container=sidecar", method="GET")\n- If you encounter an error about "container name must be specified", the error handler will automatically provide guidance to the user\n- IMPORTANT: Parse user requests carefully to detect if they\'re specifying a container name in their request:\n - Look for patterns like "container [name]", "from container [name]", "[pod-name] [container-name]"\n - If user specifies a container name, use it directly in the log URL\n - If user doesn\'t specify a container and the pod has multiple containers, fetch pod details first to list available containers' is too long - 'tools.0.function.description'",
       "type": "invalid_request_error",
       "param": null,
       "code": null
   }
}

Signed-off-by: Ashu Ghildiyal <aghildiyal@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

- Replace plain textarea with professional editor dialog - Add MCPServer interface support for environment variables - Update example configuration with modern MCP server setups - Add configuration summary with server count and status display - Integrate MCPConfigEditorDialog for better user experience - Show detailed server list with enabled/disabled status - Remove complex JSON validation in favor of editor dialog approach Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

- Add isElectron utility function for environment detection - Enhance ToolConfigManager with configuration validation - Update AIInputSection with improved tool integration - Add electron client improvements for MCP communication - Include helper functions for better component integration Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

The "white-space: pre-wrap" left lots of spacing around the text. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

So we don't show very long descriptions in the tools dialog. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Instead of just relying on editing JSON. Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ashu8912 marked this pull request as draft September 8, 2025 17:33

ashu8912 force-pushed the add-mcp-server branch 2 times, most recently from aa9aa8e to 3bd4cbb Compare September 10, 2025 04:21

ashu8912 force-pushed the add-mcp-server branch 3 times, most recently from 10b04e6 to 1b93e58 Compare September 21, 2025 11:11

ashu8912 marked this pull request as ready for review September 29, 2025 13:29

ashu8912 force-pushed the add-mcp-server branch 2 times, most recently from 2620b42 to fe38c68 Compare September 29, 2025 14:12

illume added ai-assistant enhancement New feature or request labels Oct 8, 2025

ashu8912 force-pushed the add-mcp-server branch 2 times, most recently from c81b4a7 to 628ad14 Compare October 9, 2025 11:54

ashu8912 force-pushed the add-mcp-server branch 5 times, most recently from 1f9cd8a to d9bb4cb Compare October 29, 2025 08:21

illume requested a review from Copilot November 3, 2025 10:10

illume changed the title ~~Add ability to run mcp server from ai-assistant plugin~~ ai-assistant: Add ability to run mcp server from ai-assistant plugin Nov 3, 2025

illume approved these changes Nov 3, 2025

View reviewed changes

Copilot AI reviewed Nov 3, 2025

View reviewed changes

illume marked this pull request as draft November 3, 2025 19:45

illume mentioned this pull request Nov 7, 2025

WIP: app: Add MCP server support for ai-assistant kubernetes-sigs/headlamp#4135

Draft

14 tasks

illume mentioned this pull request Nov 21, 2025

WIP: ai-assistant: Add MCP support #453

Open

ashu8912 force-pushed the add-mcp-server branch 2 times, most recently from 4e72235 to 2a74422 Compare February 17, 2026 09:33

ai-plugin: add mcp adapter

9577de0

Signed-off-by: Ashu Ghildiyal <aghildiyal@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ashu8912 and others added 26 commits February 17, 2026 15:07

ai-plugin: Run formatter

093c0bb

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Markdown rendering for document responses and UI fixes

75d7bee

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Enhance tool arguments through ai calls

adc7ca7

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Add search to mcp tools

a5d4e8f

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: Fix rendering of messages especially with bullet points

c715d5f

The "white-space: pre-wrap" left lots of spacing around the text. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: List MCP tools per MCP server in the tools dialog

5b5b386

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: Add shortDescription to the Tool class

e522287

So we don't show very long descriptions in the tools dialog. Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: Properly look for whether we are running in-desktop

fdd4c24

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: Add tool test prompts

82a3b0a

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: Improve the tool UI and UX

f974071

Signed-off-by: Joaquim Rocha <joaquim.rocha@microsoft.com> Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Fix k8s tool call working

0c77b61

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: fix log fetch failures

9756538

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: add missing tool response

21defc5

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Use mcp tools config update from electron main process

930a0d5

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Remove logs and cleanup

eeb9bad

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Fix tool args passing

00fa652

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: UI fixes

f8cc189

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Format and lint fixes

10322b3

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: React to cluster change

87c1ac6

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Fix rendering issues

3f3f688

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Remove unused code

9f3e6ec

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-plugin: Allow multiple tool calls to happen

c1b21ca

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ai-assistant: Add a GUI for managing MCP servers

66c10fd

Instead of just relying on editing JSON. Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

Fix mcp tool selection and make it fast

65fbf67

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ashu8912 force-pushed the add-mcp-server branch 2 times, most recently from f089f2f to 19b39dc Compare February 17, 2026 09:57

format and lint fix

f4505ad

Signed-off-by: ashu8912 <aghildiyal@microsoft.com>

ashu8912 force-pushed the add-mcp-server branch from 19b39dc to f4505ad Compare February 17, 2026 10:21

		return this.filterMCPArguments(inputValue, inputSchema);
		return this.filterMCPArguments(inputValue, inputSchema);

	let type: FormattedMCPOutput['type'] = 'text';
	let type: FormattedMCPOutput['type'];

Conversation

ashu8912 commented Sep 8, 2025

Uh oh!

illume left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

illume commented Nov 4, 2025

Uh oh!

illume commented Nov 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

illume left a comment •

edited

Loading

illume commented Nov 7, 2025 •

edited

Loading