Skip to content

Link dialog improvements#6

Open
jondkinney wants to merge 1 commit intomainfrom
link-dialog-improvements
Open

Link dialog improvements#6
jondkinney wants to merge 1 commit intomainfrom
link-dialog-improvements

Conversation

@jondkinney
Copy link
Copy Markdown
Member

Summary

  • Position link dialog near selected text using saved selection rect
  • Auto-prepend https:// for bare domains (google.com, headway.io)
  • Change input from type=url to type=text for looser validation
  • Overlay-based selection highlight with pixel-perfect positioning (replaces CSS Custom Highlight API)
  • Pin dropdown open via data-pinned to prevent toolbar auto-close

Test plan

  • Select text and click link button — dialog appears near selection
  • Type bare domain (e.g. google.com) — auto-prepends https://
  • Selection highlight visible while link input is focused
  • Enter in input applies link without submitting parent form

🤖 Generated with Claude Code

@jondkinney jondkinney force-pushed the link-dialog-improvements branch 2 times, most recently from 11aeb4a to d62a0a1 Compare March 27, 2026 20:49
- Position link dialog near selected text using saved selection rect
- Auto-prepend https:// for bare domains
- Change input from type=url to type=text for looser validation
- Overlay-based selection highlight with pixel-perfect positioning
- Pin dropdown open via data-pinned to prevent toolbar auto-close
- Guard against missing input element in connectedCallback
- Update test selector for new input type

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@jondkinney jondkinney force-pushed the link-dialog-improvements branch from d62a0a1 to 52f2b24 Compare March 27, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant