fix(server): avoid phantom router entry on proxy last-used bump#155
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fixes #154 by changing
server_models::proxy_requestto updatelast_usedviamapping.find(name)instead ofmapping[name]. If the model entry disappears during a concurrent reload/remove race, the bump is skipped instead of default-inserting an emptyinstance_t.Why
proxy_requestresolves metadata before proxying, then optionally bumps LRU state under the mutex. The oldoperator[]access could create a phantom UNLOADED model entry if the canonical model was erased between those steps. That phantom could appear in/modelsand later drive an empty-preset child spawn.Validation
git diff --checkcmake --build build --target llama-server -j 8./build/bin/llama-server --version