fix(server): preserve tool result adjacency in compat converters#156
Draft
marksverdhei wants to merge 1 commit into
Draft
fix(server): preserve tool result adjacency in compat converters#156marksverdhei wants to merge 1 commit into
marksverdhei wants to merge 1 commit into
Conversation
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
OpenAI-compatible message ordering requires a tool result to remain adjacent to the preceding assistant tool call. Both converters collected tool results and appended them after ordinary text from the same source turn, producing assistant -> user -> tool instead of assistant -> tool -> user.
The separate Gemini duplicate-ID behavior for parallel same-name calls is intentionally unchanged because it requires cross-turn response pairing.
Validation
Fixes #151