Skip to content

Bring main to release#182

Merged
bputzeys merged 11 commits intoreleasefrom
main
Feb 5, 2025
Merged

Bring main to release#182
bputzeys merged 11 commits intoreleasefrom
main

Conversation

@bputzeys
Copy link
Collaborator

@bputzeys bputzeys commented Feb 4, 2025

No description provided.

@bputzeys bputzeys requested review from giogix2 and mattwoodx February 4, 2025 17:05
@bputzeys bputzeys merged commit 86fa264 into release Feb 5, 2025
8 checks passed
assert mock_data.var[mock_data.var['gene_symbols'] == 'PLEKHN1']['ensembl_id'].values[0] == 'ENSG00000187583'
assert mock_data.var[mock_data.var['gene_symbols'] == 'HES4']['ensembl_id'].values[0] == 'ENSG00000188290'

def test_process_data_mapping_to_ensemble_ids_resulting_in_0_genes(self, geneformer, mock_data):

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor typo: name of the function should be test_process_data_mapping_to_ensembl_ids (ensembl instead of ensemble)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(apologies for intruding - I was checking the repository after learning about HelicalAI during the Festival of Genomics, and I saw this commit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants