Conversation
self.data_dir is not None. If self.data_dir is None, file_path remains undefined but is still used in the load_data call.
auxiliary information from the data. - setting aux_vocab_path and aux_cols to None in the example file - fix bug where if clause (if self.model_config.use_aux:) would throw an error because use_aux was not present in the config - filter out the state dict to not include aux_embeddings
Include other functionalities later
incorrectly. logging.disable() is a function that takes a level parameter, but it's not meant to be used as a context manager or to be called multiple times like this. Instead, we should use logging.getLogger().setLevel() to temporarily change the logging level.
all be done in the TranscriptFormerConfig class.
add 'unknown' as default
object as intended by the authors. This includes option to return log-likelihoods
TranscriptFormer
all depends on pyproject.toml
maxiallard
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.