Conversation
* missing import and test for quantisation * fix double logging * add time and do not remove root loggers - not needed --------- Co-authored-by: Maxime Allard <maxime@helical-ai.com> Co-authored-by: Benoit Putzeys <157973952+bputzeys@users.noreply.github.com>
sparse dataset scgpt
bputzeys
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to logging, expands support for sparse matrices in the
scgptdataset, and adds a new test for quantization initialization. The most impactful changes are the enhanced handling of sparse matrices for efficient data access and serialization, and the refinement of logging configuration for better clarity and control. Additionally, the package version is bumped and a dependency is added.Logging improvements:
helical/__init__.pyto use a dedicatedhelicallogger, improved formatting to include timestamps, and disabled propagation to the root logger for clearer, project-specific log output.helical/models/transcriptformer/utils/utils.pyto use a module-specific logger instead of global configuration.Sparse matrix support and dataset enhancements:
scgptdataset (helical/models/scgpt/dataset.py): tracks matrix type, handles serialization/deserialization, and retrieves rows as dense arrays only when needed, improving memory usage and performance. [1] [2]process_datainscgpt/model.pyto use the rawadata.Xmatrix, supporting both sparse and dense formats.Testing improvements:
test_c2s.py, verifying correct device assignment and quantization configuration.Package management:
1.4.15and addedprotobuf>=3.20.0to dependencies inpyproject.toml. [1] [2]