change the children's key to be unique to able html mouse events#46
Open
hartuvofir wants to merge 25 commits intohelior:coverallfrom
bookmd:master
Open
change the children's key to be unique to able html mouse events#46hartuvofir wants to merge 25 commits intohelior:coverallfrom bookmd:master
hartuvofir wants to merge 25 commits intohelior:coverallfrom
bookmd:master
Conversation
Add Coveralls.io integration
No longer rely upon React.__spread which is breaking on 15.0. Also use React.createElement directly rather than React.DOM.span.
Bump react peer dependency to allow v14 and v15
Use React.createElement to allow usage with React 15.0.
# Conflicts: # package.json
Update for React v15
Add 'js' to README
blacklist custom props
Fixes deprecation warnings in React 15.5.0
Specifically create-react-class and prop-types"
|
Changes Unknown when pulling cac0495 on bookmd:master into ** on helior:master**. |
Contributor
|
@hartuvofir I'd suggest you remove all the IntelliJ related files from the PR and keep only the relevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The File i changed is lib/highlighter.js .
The problem was that the item key (count), was not unique between the items (i debug the html) -
and react cant capture click/mouse events in this case.
I changed it to be based by the Address(string), which is unique.