This repository was archived by the owner on Jun 12, 2023. It is now read-only.
Use the correct chain var for bloom filter reset#1594
Open
mawdegroot wants to merge 1 commit intohelium:masterfrom
Open
Use the correct chain var for bloom filter reset#1594mawdegroot wants to merge 1 commit intohelium:masterfrom
mawdegroot wants to merge 1 commit intohelium:masterfrom
Conversation
Contributor
|
This likely needs some testing but it also needs a guard around rollback scenario if we (unlikely) roll back the light hotspot activation. |
Contributor
Author
|
From what I understood the How do I best test this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running with validator challenges the bloom filter is still reset using
poc_challenge_intervalwhich is not used with validator challenges. Change to the correct chain variable and useGatewayCount / PocChallengeRateto mimic old bloom filter behavior.blockchain_ledger_v1:gateway_countis quite slow so adding it to the record to cache the result for the duration of one interval length.