Separate ordinary materialization from GPU materialization, examples on how to run naive matmul using both - #142
Closed
mstn wants to merge 3 commits into
Closed
Separate ordinary materialization from GPU materialization, examples on how to run naive matmul using both#142mstn wants to merge 3 commits into
mstn wants to merge 3 commits into
Conversation
Closed
Contributor
Author
|
outdated after #152 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, ordinary
materializeimplicitly launched a GPU kernel. This mixed functional buffer construction with GPU scheduling and made it difficult to distinguish a normal materialization from an explicitly parallel one.The PR separates these responsibilities:
Ordinary
materializenow follows the functional interpretation:Codegen lowers it to a sequential host loop without a kernel launch or device synchronization.
gpu.materializeremains the explicit GPU operation. It takes launch parameters and schedules one kernel invocation per logical thread.The existing naive matmul uses ordinary
materialize.A new GPU naive matmul uses the same matrix-view and
cell-dotlogic throughgpu.materialize, making the scheduling choice explicit.Only nested
gpu.materializeare not allowed because we don't want to launch kernels from a kernel for now.Tests
Ordinary
materializewith naive matmul:gpu.materializewith naive matmul:gpu.materializewith tiled matmul: