Add function signature validation for type annotations#365
Open
nbeerbower wants to merge 1 commit into
Open
Conversation
Previously, function-type annotations (e.g., `fn(i32): i32`) only checked that a value was a function, without validating parameter counts, types, return types, or async flags. This change adds proper signature validation. Changes: - Add validate_function_signature() to types.c for comprehensive signature checking including parameter count, types, return type, and async flag - Add types_compatible() helper for comparing types recursively - Add format_type() helper for generating readable error messages - Add type_copy() to ast.c for deep copying Type structures including all function-type fields (fn_param_types, fn_return_type, etc.) - Update expressions.c to use type_copy() for parameter and return types - Add parity test for function signature validation The validation properly handles: - Exact signature matches - Untyped functions with typed annotations (dynamic compatibility) - Numeric type compatibility (i32/i64/f32/f64) - Async/non-async function distinction - Optional parameters and defaults
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, function-type annotations (e.g.,
fn(i32): i32) only checked that a value was a function, without validating parameter counts, types, return types, or async flags. This change adds proper signature validation.Changes:
The validation properly handles: