Validate function type annotations at runtime and add signature mismatch tests#369
Open
nbeerbower wants to merge 1 commit into
Open
Validate function type annotations at runtime and add signature mismatch tests#369nbeerbower wants to merge 1 commit into
nbeerbower wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Typestructures andtypes_compatiblelogic for comparing function parameter and return types.Description
type_matches_function_signature(Type *expected_type, Function *func, const char **error_msg)that constructs a temporaryTypefor the actual function and validates async flag, parameter count/types, rest param, and return type usingtypes_compatibleandtype_to_stringfor formatting.convert_to_typeso when thetarget_typeisTYPE_FUNCTIONand the value isVAL_FUNCTIONit calls the helper and emits a runtime error with both expected and actual signatures if validation fails.Type,types_compatible,type_to_string) rather than introducing new signature representations.tests/functions/function_signature_param_error.hmlandtests/functions/function_signature_return_error.hmlwith corresponding.expectedfiles asserting the runtime error messages.Testing
tests/functions/function_signature_param_error.hmlandtests/functions/function_signature_return_error.hmlwith expected outputs showing the mismatch messages.Function signature mismatch (expected <expected_sig>, got <actual_sig>).Codex Task