Verify pkg/addr#5
Merged
Merged
Conversation
There still remain a lot of assumptions due to Gobra issues
Most notably sensitivity requirements in interfaces have been made uniform
Note that the way `strings.Builder` is annotated may not be final
…into sif-pkg-addr
... in `fmt.Stringer` and `flag.Value`
This also allowed the removal of several workarounds for bugs 835/890
This was referenced Jul 31, 2025
Closed
jcp19
reviewed
Aug 5, 2025
Owner
Author
|
@jcp19: I have addressed all your feedback now. The removal of the restriction |
jcp19
approved these changes
Aug 14, 2025
jcp19
left a comment
jcp19
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, please look at my comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues #13, #14 and #15 have been opened to keep track of the assumptions still present here.