Verify private/underlay/conn#6
Merged
Merged
Conversation
…into sif-private-underlay-conn
`isZeros` now has accompanying `isZeroSpec` with implementation s.t. one can infer `low(isZeros(s))` if the elements of `s` are low. `NewReadMessages` has different triggers to hopefully improve stability (Joao's suggestion). Cannot really test yet, since package is now failing (cf. Gobra issue #948)
I adjusted private/underlay/conn/conn.go, `New` accordingly
jcp19
reviewed
Aug 6, 2025
Owner
Author
|
@jcp19: Besides addressing your feedback, I have performed the following modifications:
|
jcp19
reviewed
Aug 29, 2025
jcp19
reviewed
Aug 29, 2025
jcp19
reviewed
Aug 29, 2025
jcp19
left a comment
jcp19
left a comment
Collaborator
There was a problem hiding this comment.
After my comments are addressed, this should be ready to merge
As `UDPConn` is "abstract" (i.e. only defined using `PrivateField`), the issue here is not of not being able to implement `IsLow`, only that we still need to add `hyper` to it. Update comment accordingly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues #14, #15 and #16 have been opened to keep track of the assumptions still present here.