Clean up redundant SQLAlchemyError handling in ti_run after app-level handler added#8
Closed
Copilot wants to merge 3 commits intoreplace-to-fastapi-custom-exceptionfrom
Closed
Clean up redundant SQLAlchemyError handling in ti_run after app-level handler added#8Copilot wants to merge 3 commits intoreplace-to-fastapi-custom-exceptionfrom
Copilot wants to merge 3 commits intoreplace-to-fastapi-custom-exceptionfrom
Conversation
1 task
Co-authored-by: henry3260 <108824346+henry3260@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix SQLAlchemyError handling via app exception handler
Clean up redundant SQLAlchemyError handling in ti_run after app-level handler added
Feb 22, 2026
henry3260
force-pushed
the
replace-to-fastapi-custom-exception
branch
3 times, most recently
from
1b7646e to
196c09f
Compare
Copilot stopped work on behalf of
henry3260 due to an error
February 27, 2026 08:44
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #6 added a centralized
SQLAlchemyErrorexception handler inapp.py, but left a no-optry/exceptinti_runthat catches and immediately re-raises with no side effects.Changes
task_instances.py: Remove the redundanttry/except SQLAlchemyError: raiseblock wrapping the body ofti_run— the app-level handler inapp.pyalready covers thistask_instances.py: Remove now-unusedSQLAlchemyErrorfrom thesqlalchemy.excimportThe
ti_update_statefunction was already correctly cleaned up in PR #6 (try-except removed entirely). This bringsti_runin line with the same pattern.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.