.getBytes called without charset#2
Open
iarenaza wants to merge 9 commits intohenrygarner:masterfrom
Open
Conversation
From the original issue at henrygarner#1 > I had different CRC32 checksums returned for the same string on > different machines, because .getBytes is called without specifying a > character encoding. The default encoding will be used, which is > unspecified. > > I believe you should be calling it with utf-8 specified. Implement a protocol that allows us to call the CRC methods on both strings and raw byte arrays. When using strings, let the caller specify an optional parameter stating the string character encoding (using any of the standard Java character encoding names). If the optional parameter is not specified, "UTF-8" is used.
This is the only missing checksum from digest-crc[1] ruby gem, which is the inspiration for biscuit. [1] https://github.com/postmodern/digest-crc
See [:wrong-tag warnings in uses of extend-type and extend-protocol macro](https://github.com/jonase/eastwood/blob/master/README.md#wrong-tag-warnings-in-uses-of-extend-type-and-extend-protocol-macro) for the relevant details.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From issue #1
Implement a protocol that allows us to call the CRC methods on both strings and raw byte arrays. When using strings, let the caller specify an optional parameter stating the string character encoding (using any of the standard Java character encoding names). If the optional parameter is not specified, "UTF-8" is used.
Also implement CRC64 checksum. This was the only missing checksum from digest-crc ruby gem, which is the inspiration for biscuit.