Open
Conversation
This can be set in the config file or on the command line, e.g. `--setopt=aws.container_credentials_path=$AWS_CONTAINER_CREDENTIALS_RELATIVE_URI`
The container metadata server cannot be used if the default metadata server http://169.254.169.254 is specified in the config file.
The use of `--setopt=...` described in commit c417342 unfortunately has no effect.
The PLUGINS doc doesn't mention this possibility, but the pattern in other Yum plugins is clear.
The latest Python packages for Amazon Linux 2 incorporate a fix for CVE-2022-0391, which makes the `urlsplit` function remove newlines and tabs from the URL.
RulerOf
approved these changes
Jun 21, 2022
RulerOf
left a comment
RulerOf
left a comment
There was a problem hiding this comment.
FWIW, these changes look good to me and are functioning well in my environment.
I recommend merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits fix issues #11 and #12, and also add support for the ECS metadata service.