refactor: extract shared utilities, fix null-safety bugs, prune trivi…#86
Merged
Conversation
…al tests - Extract ExecutionResultHandler to deduplicate result-switch logic between WorkflowExecutionService and ExecutionStateService - Extract WorkflowContextUtil with null-safe context filtering (fixes Collectors.toMap NPE on null values) - Add CredentialsStore to CLI for structured credential management - Add ShellEscaper utility to core for safe shell argument escaping - Fix ExecutionStateService catch block: persist "failed" snapshot on resume crash (was leaving DB stuck in "paused") - Fix McpToolDiscovery cache race: stale entries no longer resurface after concurrent invalidation - Prune ~3300 lines of trivial/tautological tests across CLI, DSL, and server modules - Add meaningful tests: parameterised ExecutionResultHandler coverage, null-value regression, resume-crash snapshot persistence Signed-off-by: Aleksandr Suvorov <asuvorov@hensu.io>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Aleksandr Suvorov <asuvorov@hensu.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…al tests