[litmus] Enable check_dic_idc for PreSi and Kvm modes#1727
Open
diaolo01 wants to merge 1 commit intoherd:masterfrom
Open
[litmus] Enable check_dic_idc for PreSi and Kvm modes#1727diaolo01 wants to merge 1 commit intoherd:masterfrom
diaolo01 wants to merge 1 commit intoherd:masterfrom
Conversation
relokin
reviewed
Feb 27, 2026
| | Some cache_type -> cache_type.dic, cache_type.idc in | ||
| begin match forall_procs test needs_dic, forall_procs test needs_idc with | ||
| | Some dic, Some idc -> | ||
| O.fi "check_dic_idc(%d, %d);" (if dic then 1 else 0) |
Member
There was a problem hiding this comment.
It seems like we are checking DIC/IDC on one core and we assume that it's the same for all cores? Is that a good assumption?
If yes can you please add a comment here?
Contributor
Author
There was a problem hiding this comment.
Actually, this code was checking per core rather than a single core. The Arm ARM states: "All PEs in the same Inner Shareable shareability domain must have a common value of this field.".
I moved the check at the test level to match what is done for hardware updates. I have included a comment to capture the requirement above.
diaolo01
force-pushed
the
fix-dic-idc
branch
2 times, most recently
from
ff89561 to
5763872
Compare
relokin
reviewed
Mar 30, 2026
Member
relokin
left a comment
relokin
left a comment
There was a problem hiding this comment.
Two comments, otherwise this PR looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables PreSi and Kvm modes to check whether a core has DIC/IDC implemented. It also runs tests with
DIC=0 & IDC=0as part ofmake-aarch64-litmus, while only compiling tests that require either DIC or IDC.=====
This has been identified as part of #1716. This fix has been tested against that patch and the desired behaviour was observed on an M2:
The missing call was not flagged by the compiler because GCC/Clang do not warn about unused
static inlinefunctions by default.