fix(input): handle kitty shift-tab in settings - #2557
Open
akbash-bot wants to merge 1 commit into
Open
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughSettings key handling now dispatches normalized key codes across all sections. A regression test verifies Kitty keyboard protocol Shift+Tab navigation from Indicators to Theme. The changelog records the fix. ChangesSettings navigation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
LGTM. Checked and it works |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tab + Shiftbefore Settings section dispatchChecks
cargo test app::input::settings::tests::kitty_shift_tab_moves_to_previous_settings_section -- --exact --nocapturecargo test app::input::settings::tests -- --nocapturejust ci 'all() - test(live_server_holds_one_pty_master_fd_per_pane)'(3333 tests passed; the excluded harness requirestarget/debug/herdrinside the checkout, while Kennel supplies an isolated externalCARGO_TARGET_DIR)just windows-lintrefs #2556