Skip to content

fix(input): handle kitty shift-tab in settings - #2557

Open
akbash-bot wants to merge 1 commit into
masterfrom
akbash/2556-shift-tab-settings
Open

fix(input): handle kitty shift-tab in settings#2557
akbash-bot wants to merge 1 commit into
masterfrom
akbash/2556-shift-tab-settings

Conversation

@akbash-bot

Copy link
Copy Markdown
Collaborator

Summary

  • canonicalize Kitty-style Tab + Shift before Settings section dispatch
  • keep plain Tab moving forward while Shift+Tab moves backward
  • cover the raw Kitty sequence through the Settings state transition

Checks

  • cargo test app::input::settings::tests::kitty_shift_tab_moves_to_previous_settings_section -- --exact --nocapture
  • cargo test app::input::settings::tests -- --nocapture
  • just ci 'all() - test(live_server_holds_one_pty_master_fd_per_pane)' (3333 tests passed; the excluded harness requires target/debug/herdr inside the checkout, while Kennel supplies an isolated external CARGO_TARGET_DIR)
  • just windows-lint
  • maintenance unittest suite (98 passed)

refs #2556

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e4bc6dd7-ec3f-4072-b9b8-67c9d5162002

📥 Commits

Reviewing files that changed from the base of the PR and between d277d2f and 1eed66b.

📒 Files selected for processing (2)
  • docs/next/CHANGELOG.md
  • src/app/input/settings.rs

📝 Walkthrough

Walkthrough

Settings key handling now dispatches normalized key codes across all sections. A regression test verifies Kitty keyboard protocol Shift+Tab navigation from Indicators to Theme. The changelog records the fix.

Changes

Settings navigation

Layer / File(s) Summary
Normalized settings key dispatch
src/app/input/settings.rs, docs/next/CHANGELOG.md
update_settings_state uses normalized key codes for settings-section handling. The regression test verifies Shift+Tab navigation from Indicators to Theme. The changelog records the fix.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • herdrdev/herdr#2340: Both PRs modify Kitty protocol keyboard handling in different input components.
  • herdrdev/herdr#2479: Both PRs address Shift-key handling for Kitty keyboard protocol input.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing Kitty Shift+Tab handling in Settings.
Description check ✅ Passed The description directly explains the input-handling change, navigation behavior, tests, and related issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch akbash/2556-shift-tab-settings

Comment @coderabbitai help to get the list of available commands.

@kangal-bot kangal-bot added the ai-review Trigger automated AI reviews for pull requests admitted by the PR gate label Aug 9, 2026
@affanali2k3

Copy link
Copy Markdown

LGTM. Checked and it works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review Trigger automated AI reviews for pull requests admitted by the PR gate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants