feat: show a zoom indicator in the desktop tab bar - #2560
Conversation
Reserve the right edge of the tab row for a ZOOM pill while the focused pane is zoomed, matching the accent style of the mode bars. The per-tab Z suffix stays; the pill makes the zoomed state visible at a glance like tmux's status-right flag.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe desktop tab bar now shows a right-aligned ChangesDesktop tab-bar zoom indicator
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…oom-indicator # Conflicts: # docs/next/CHANGELOG.md
Greptile SummaryThe PR adds a fixed right-aligned zoom indicator to the desktop tab bar and reserves layout space for it while the active tab is zoomed.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The zoom predicate follows the active tab’s state, and the reserved-width rendering path consistently keeps normal tab-bar content outside the indicator.
|
| Filename | Overview |
|---|---|
| src/ui/tabs.rs | Adds zoom-indicator layout, rendering, and tests without an identified actionable defect. |
| docs/next/CHANGELOG.md | Accurately documents the new desktop tab-bar zoom indicator. |
Reviews (1): Last reviewed commit: "Merge remote-tracking branch 'upstream/m..." | Re-trigger Greptile
|
superseded by #2586 with the new |
Summary
ZOOMpill in the desktop tab bar while the focused pane is zoomed, styled like the mode bars (accent background, bold contrast text)compute_tab_bar_viewso tabs, scroll buttons, the+button, and the overflow ellipsis never render underneath itZlabel suffix stays for background tabsThe per-tab
Zmarker is easy to miss when scanning the bar; a fixed-position indicator gives the zoomed state one stable place to look, matching what tmux users get from#{?window_zoomed_flag,ZOOM ,}in status-right.Testing