This repository was archived by the owner on Mar 8, 2023. It is now read-only.
Default to triangle mesh mode when generating a single .terrain file#67
Open
jtfell wants to merge 1 commit intoheremaps:masterfrom
jtfell:terrain-output-dem2tin.jtfell
Open
Default to triangle mesh mode when generating a single .terrain file#67jtfell wants to merge 1 commit intoheremaps:masterfrom jtfell:terrain-output-dem2tin.jtfell
jtfell wants to merge 1 commit intoheremaps:masterfrom
jtfell:terrain-output-dem2tin.jtfell
Conversation
Signed-off-by: Julian Fell <hi@jtfell.com>
Author
Open
qGYdXbY2
added a commit
to qGYdXbY2/tin-terrain
that referenced
this pull request
Feb 27, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #65. I don't have a deep understanding of the library by any stretch but from what I can tell, the
optimal_mesh_modefunction is only used in thedem2tinsubcommand which is where the problem reported in #65 comes up.Can you try this branch and confirm that your issue is resolved @rapit?