Supports non-rustc-built-in target.cfg.dependencies#149
Conversation
|
@dzbarsky may I have a review from you? |
|
To be honest I don't understand this PR. It does look like the existing built-in mappings are incomplete, but that seems like it can be handled via fleshing them out rather than needing to compute them on the fly; aren't they immutable? Then, if you just want to have an extra It also seems odd to me to specify a |
Because we must confirm whether rustc actually activates the flag, we can optimize this by caching the
People might write code like this, using cfg because sdk_dev can't be a feature—doing so would break the additivity of Cargo features. The downside: if --cfg=sdk_dev is missing at resolution time, hack_tls_cert won't be pulled into the dependency graph. |
Fix #148