Skip to content

fix(virtio): do not fail on device configuration change if possible#2464

Open
cagatay-y wants to merge 1 commit into
hermit-os:mainfrom
cagatay-y:fix-ignore-cfg-change
Open

fix(virtio): do not fail on device configuration change if possible#2464
cagatay-y wants to merge 1 commit into
hermit-os:mainfrom
cagatay-y:fix-ignore-cfg-change

Conversation

@cagatay-y
Copy link
Copy Markdown
Contributor

Some of the device configuration change interrupts are only relevant if configuration values are cached by the driver. However, we do not make use of any such configurations. Thus, only panic if the interrupt is sent because the device needs reset, which we currently cannot handle and must not ignore.

Some of the device configuration change interrupts are only relevant if
configuration values are cached by the driver. However, we do not make
use of any such configurations. Thus, only panic if the interrupt is
sent because the device needs reset, which we currently cannot handle
and must not ignore.
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark Results

Details
Benchmark Current: cc6eee4 Previous: 28c7089 Performance Ratio
startup_benchmark Build Time 114.72 s 115.28 s 1.00
startup_benchmark File Size 0.77 MB 0.77 MB 1.00
Startup Time - 1 core 0.99 s (±0.08 s) 1.00 s (±0.03 s) 0.99
Startup Time - 2 cores 0.97 s (±0.04 s) 1.04 s (±0.05 s) 0.94
Startup Time - 4 cores 1.03 s (±0.04 s) 1.00 s (±0.06 s) 1.03
multithreaded_benchmark Build Time 118.43 s 118.33 s 1.00
multithreaded_benchmark File Size 0.87 MB 0.87 MB 1.00
Multithreaded Pi Efficiency - 2 Threads 90.47 % (±14.28 %) 92.34 % (±11.70 %) 0.98
Multithreaded Pi Efficiency - 4 Threads 44.61 % (±6.41 %) 45.83 % (±5.87 %) 0.97
Multithreaded Pi Efficiency - 8 Threads 24.57 % (±3.68 %) 25.71 % (±3.50 %) 0.96
micro_benchmarks Build Time 96.08 s 96.08 s 1.00
micro_benchmarks File Size 0.88 MB 0.88 MB 1.00
Scheduling time - 1 thread 73.55 ticks (±3.95 ticks) 73.85 ticks (±3.74 ticks) 1.00
Scheduling time - 2 threads 40.86 ticks (±4.11 ticks) 41.46 ticks (±4.37 ticks) 0.99
Micro - Time for syscall (getpid) 3.07 ticks (±0.26 ticks) 3.08 ticks (±0.19 ticks) 1.00
Memcpy speed - (built_in) block size 4096 73218.26 MByte/s (±50424.59 MByte/s) 73208.48 MByte/s (±50616.82 MByte/s) 1.00
Memcpy speed - (built_in) block size 1048576 29333.38 MByte/s (±24058.77 MByte/s) 29392.18 MByte/s (±24125.47 MByte/s) 1.00
Memcpy speed - (built_in) block size 16777216 24730.49 MByte/s (±20489.43 MByte/s) 23751.74 MByte/s (±19605.56 MByte/s) 1.04
Memset speed - (built_in) block size 4096 72840.24 MByte/s (±50194.29 MByte/s) 73313.38 MByte/s (±50689.78 MByte/s) 0.99
Memset speed - (built_in) block size 1048576 30081.44 MByte/s (±24486.11 MByte/s) 30169.43 MByte/s (±24587.38 MByte/s) 1.00
Memset speed - (built_in) block size 16777216 25062.93 MByte/s (±20617.50 MByte/s) 24402.29 MByte/s (±20008.02 MByte/s) 1.03
Memcpy speed - (rust) block size 4096 65643.35 MByte/s (±45828.02 MByte/s) 66427.37 MByte/s (±46490.49 MByte/s) 0.99
Memcpy speed - (rust) block size 1048576 29549.16 MByte/s (±24287.80 MByte/s) 29425.11 MByte/s (±24175.79 MByte/s) 1.00
Memcpy speed - (rust) block size 16777216 23338.24 MByte/s (±19170.50 MByte/s) 24403.77 MByte/s (±20179.96 MByte/s) 0.96
Memset speed - (rust) block size 4096 66132.24 MByte/s (±46160.22 MByte/s) 66262.32 MByte/s (±46403.75 MByte/s) 1.00
Memset speed - (rust) block size 1048576 30329.96 MByte/s (±24734.74 MByte/s) 30172.11 MByte/s (±24599.55 MByte/s) 1.01
Memset speed - (rust) block size 16777216 23748.24 MByte/s (±19363.30 MByte/s) 25069.95 MByte/s (±20590.63 MByte/s) 0.95
alloc_benchmarks Build Time 91.48 s 91.43 s 1.00
alloc_benchmarks File Size 0.85 MB 0.85 MB 1.00
Allocations - Allocation success 100.00 % 100.00 % 1
Allocations - Deallocation success 100.00 % 100.00 % 1
Allocations - Pre-fail Allocations 100.00 % 100.00 % 1
Allocations - Average Allocation time 4541.08 Ticks (±56.14 Ticks) 4633.96 Ticks (±62.19 Ticks) 0.98
Allocations - Average Allocation time (no fail) 4541.08 Ticks (±56.14 Ticks) 4633.96 Ticks (±62.19 Ticks) 0.98
Allocations - Average Deallocation time 1003.30 Ticks (±107.29 Ticks) 683.28 Ticks (±99.25 Ticks) 1.47
mutex_benchmark Build Time 89.75 s 90.68 s 0.99
mutex_benchmark File Size 0.88 MB 0.88 MB 1.00
Mutex Stress Test Average Time per Iteration - 1 Threads 13.94 ns (±0.79 ns) 13.82 ns (±0.84 ns) 1.01
Mutex Stress Test Average Time per Iteration - 2 Threads 18.90 ns (±10.19 ns) 14.48 ns (±0.75 ns) 1.31

This comment was automatically generated by workflow using github-action-benchmark.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant