Skip to content

Improve xtask#556

Open
fogti wants to merge 2 commits intohermit-os:mainfrom
fogti:improve-xtask
Open

Improve xtask#556
fogti wants to merge 2 commits intohermit-os:mainfrom
fogti:improve-xtask

Conversation

@fogti
Copy link

@fogti fogti commented Feb 4, 2026

Similar to what I did for the xtask of the kernel.

Copy link
Member

@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation for making xtask ci optional here? This is not something that users are supposed to build frequently, unlike their application, and thus the kernel.

In any case, please make feature = "ci" a default feature and revert the workflow changes.

Regarding the second commit: I prefer the way it was before, except for

@@ -97,7 +84,7 @@ impl CmdExt for Cmd<'_> {
 
        fn target_dir_args(self, artifact: &Artifact) -> Self {
                if let Some(target_dir) = &artifact.target_dir {
-                       self.args::<&[&OsStr]>(&["--target-dir".as_ref(), target_dir.as_ref()])
+                       self.arg("--target-dir").arg(target_dir)
                } else {
                        self
                }

@mkroening mkroening self-assigned this Feb 4, 2026
@fogti
Copy link
Author

fogti commented Feb 4, 2026

May I ask what the weird "trip" trough Artifact::profile(&self) == "dev" is supposed to do?

@fogti
Copy link
Author

fogti commented Feb 4, 2026

This PR would make thus make it possible to reduce the build time for the release workflow, and also reduces the deps for running cargo xtask clippy (via cargo run --no-default-features -p xtask clippy) locally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants