Skip to content

Remove all thrown exceptions in Dartagnan.main()#1020

Open
hernanponcedeleon wants to merge 1 commit intodevelopmentfrom
exceptions
Open

Remove all thrown exceptions in Dartagnan.main()#1020
hernanponcedeleon wants to merge 1 commit intodevelopmentfrom
exceptions

Conversation

@hernanponcedeleon
Copy link
Copy Markdown
Owner

This solves some SVCOMP problems in which the runner was looping forever e.g., if we would pass the wrong file path.

However, we still have the looping problem if dartagnan runs OOM. It seems the jvm returns 1 as exit code, which is the same value we use for ExitCode.BOUNDED_RESULT (which is also what we used for the looping condition in the runner).

Signed-off-by: Hernan Ponce de Leon <hernanl.leon@huawei.com>
@ThomasHaas
Copy link
Copy Markdown
Collaborator

I think we should simply use different exit codes and avoid the common one's like 1 (see here for some examples). I also asked ChatGPT and it mentions that several of the lower numbers 0-4 are used. I would play it safe and use exit codes starting at 30 or so.

@ThomasHaas
Copy link
Copy Markdown
Collaborator

I think we should just put UNKNOWN_ERROR on exit code 1, and then even if we have uncaught exceptions or the JVM runs out of memory, the error code is fine.
But I guess that any changes in the exit codes would require you to update Vsyncer again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants