Skip to content

Remove outdated code in RefinementSolver #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hernanponcedeleon merged 1 commit into from
Jan 17, 2026
Merged

Remove outdated code in RefinementSolver #961

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions dartagnan/src/main/java/com/dat3m/dartagnan/verification/solving/RefinementSolver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -536,11 +536,7 @@ private static RefinementModel generateRefinementModel(Wmm original) {
// (ii) Negated relations (if derived)
final Relation sub = diff.getSubtrahend();
final Definition subDef = sub.getDefinition();
if (!sub.getDependencies().isEmpty()
// The following three definitions are "semi-derived" and need to get cut
// to get a semi-positive model.
|| subDef instanceof SetIdentity
|| subDef instanceof CartesianProduct) {
if (!sub.getDependencies().isEmpty()) {
constraintsToCut.add(subDef);
}
} else if (c instanceof Definition def && def.getDefinedRelation().hasName()) {
Expand Down