Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion benchmarks/mixed/store-to-load-forwarding1.c
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@
#include <stdatomic.h>
#include <assert.h>
// Issue: Store-to-Load Forwarding may cause mixed-size atomic accesses to appear non-atomic.
// Expected: FAIL on ARMv8
// Expected: PASS on ARMv8, but FAIL on older, unpatched version of ARMv8, see
// https://github.com/herd/herdtools7/commit/2b7921a

union { atomic_ushort full; struct { atomic_uchar half0; atomic_uchar half1; }; } lock;

Expand Down
32 changes: 18 additions & 14 deletions cat/aarch64.cat
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@ let dmb.st = DMB.ISHST | DMB.OSHST | DMB.ST | dsb.st
(* Flag any use of shareability options, due to the restrictions above. *)
(*
flag ~empty (dmb.full | dmb.ld | dmb.st) \
(DMB.SY | DMB.LD | DMB.ST | DSB.SY | DSB.LD | DSB.ST)
as Assuming-common-inner-shareable-domain
(DMB.SY | DMB.LD | DMB.ST | DSB.SY | DSB.LD | DSB.ST)
as Assuming-common-inner-shareable-domain
*)

(* Coherence-after *)
Expand All @@ -83,29 +83,33 @@ let obs = rfe | fre | coe

(* Dependency-ordered-before *)
let dob = (addr | data)
| ctrl; [W]
| (ctrl | (addr; po)); [ISB]; po; [R]
| addr; po; [W]
| (addr | data); lrs
| ctrl; [W]
| (ctrl | (addr; po)); [ISB]; po; [R]
| addr; po; [W]
| (addr | data); lrs

(* Atomic-ordered-before *)
let aob = rmw
| [range(rmw)]; lrs; [A | Q]
| [range(rmw)]; lrs; [A | Q]

(* Barrier-ordered-before *)
let bob = po; [dmb.full]; po
| po; ([A];amo;[L]); po
| [L]; po; [A]
| [R]; po; [dmb.ld]; po
| [A | Q]; po
| [W]; po; [dmb.st]; po; [W]
| po; [L]
| po; ([A];amo;[L]); po
| [L]; po; [A]
| [R \ NoRet]; po; [dmb.ld]; po
| [A | Q]; po
| [W]; po; [dmb.st]; po; [W]
| po; [L]

(* Locally-ordered-before *)
let lob = lws; si | dob | aob | bob

(** Hazard-ordered-before **)
let haz-ob =
[R]; (po & loc); [R]; si?; [R]; (ca & ext); [W]; si?; [W]

(* Ordered-before *)
let ob = obs; si | lob
let ob = obs; si | lob | haz-ob

(* Internal visibility requirement *)
acyclic po-loc | ca | rf as internal
Expand Down
Loading