Teams leaderboards - #165
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new “team leaderboards” feature surface to the Teams system, exposing configuration, RPC/API contracts, and public interface methods to list/get/update team leaderboard data and fetch score lists.
Changes:
- Extends
TeamsConfigwith aleaderboardssection and introducesTeamLeaderboardsConfig. - Expands
TeamsSystemwith team-leaderboard listing/getting/updating and score-list retrieval methods, plus pre/post update hooks. - Adds new RPC IDs + protobuf messages and wires corresponding OpenAPI endpoints/schemas.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
teams.go |
Adds team leaderboard config and expands TeamsSystem with team leaderboard operations and hook type. |
hiro.proto |
Introduces new RPC IDs and protobuf messages for team leaderboard list/get/update and score listing. |
hiro-openapi.yml |
Registers new RPC endpoints and adds OpenAPI component schemas for the new team leaderboard messages. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Calm0
force-pushed
the
teams-leaderboards
branch
from
July 16, 2026 14:28
dda4dce to
db46e5b
Compare
Contributor
|
@Calm0 - can you please update https://github.com/heroiclabs/hiro/blob/main/schemas/05-Hiro-Teams.json to reflect the schema changes. |
VBorisof
reviewed
Jul 28, 2026
VBorisof
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.