Skip to content

Update Satori Personalizer to gracefully handle some error codes #172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tolgatolgay merged 1 commit into from
Jul 28, 2026
Merged

Update Satori Personalizer to gracefully handle some error codes #172

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions personalizer_satori.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,16 +446,16 @@ func (p *SatoriPersonalizer) GetValue(ctx context.Context, logger runtime.Logger
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori flag list, user not found")
return nil, nil
}
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error requesting Satori flag list")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori flag list")
return nil, nil
}

if len(flagList.Flags) >= 1 {
config = system.GetConfig()
decoder := json.NewDecoder(strings.NewReader(flagList.Flags[0].Value))
if err := decoder.Decode(config); err != nil {
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error merging Satori flag value")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error merging Satori flag value")
return nil, nil
}
found = true
}
Expand All @@ -468,8 +468,8 @@ func (p *SatoriPersonalizer) GetValue(ctx context.Context, logger runtime.Logger
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori live events list, user not found")
return nil, nil
}
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error requesting Satori live events list")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori live events list")
return nil, nil
}
if len(liveEventsList.LiveEvents) > 0 {
if config == nil {
Expand Down Expand Up @@ -498,8 +498,8 @@ func (p *SatoriPersonalizer) GetValue(ctx context.Context, logger runtime.Logger
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori flag list, user not found")
return nil, nil
}
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error requesting Satori flag list")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori flag list")
return nil, nil
}

var liveEventsList *runtime.LiveEventList
Expand All @@ -510,8 +510,8 @@ func (p *SatoriPersonalizer) GetValue(ctx context.Context, logger runtime.Logger
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori live events list, user not found")
return nil, nil
}
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error requesting Satori live events list")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori live events list")
return nil, nil
}
}

Expand Down Expand Up @@ -540,8 +540,8 @@ func (p *SatoriPersonalizer) GetValue(ctx context.Context, logger runtime.Logger
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori live events list, user not found")
return nil, nil
}
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error requesting Satori live events list")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error requesting Satori live events list")
return nil, nil
}
cacheEntry.liveEvents.Store(liveEventsList)
}
Expand All @@ -556,8 +556,8 @@ func (p *SatoriPersonalizer) GetValue(ctx context.Context, logger runtime.Logger
config = system.GetConfig()
decoder := json.NewDecoder(strings.NewReader(flHandle.Value()))
if err := decoder.Decode(config); err != nil {
logger.WithField("userID", userID).WithField("error", err.Error()).Error("error merging Satori flag value")
return nil, err
logger.WithField("userID", userID).WithField("error", err.Error()).Warn("error merging Satori flag value")
return nil, nil
}
found = true
}
Expand Down
Loading