use player location instead of nakama server - #175
Draft
iav-uk wants to merge 1 commit into
Draft
Conversation
|
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Satori integration to forward the player’s client IP address (when available in the Nakama runtime context) to Satori on server-to-server calls, so Satori’s geo-IP resolution uses the player location rather than the Nakama node’s own address.
Changes:
- Pass
runtime.RUNTIME_CTX_CLIENT_IPthrough tonk.GetSatori().Authenticate(...). - Pass
runtime.RUNTIME_CTX_CLIENT_IPthrough tonk.GetSatori().EventsPublish(...). - Add a small helper (
satoriClientIPAddress) to extract the client IP fromcontext.Contextand pass it as a variadic argument.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| return | ||
| } | ||
| if _, err := nk.GetSatori().Authenticate(ctx, userID, nil, nil, !p.IsPublishAuthenticateRequestWithSession()); err != nil && !errors.Is(err, runtime.ErrSatoriConfigurationInvalid) { | ||
| if _, err := nk.GetSatori().Authenticate(ctx, userID, nil, nil, !p.IsPublishAuthenticateRequestWithSession(), satoriClientIPAddress(ctx)...); err != nil && !errors.Is(err, runtime.ErrSatoriConfigurationInvalid) { |
iav-uk
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary:
SatoriPersonalizer.AuthenticateandSatoriPersonalizer.Sendcallednk.GetSatori().Authenticate(...) / EventsPublish(...)without an IP address, and, in calls from the Nakama node to Satori, Satori's geo-IP lookup (satori/server/api_authenticate.go/extractClientAddressFromContext) is falling back to the Nakama server's own peer address instead of the player's