Implement notransaction option and wrap statement errors - #6
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for notransaction migrations by executing planned statements directly on the connection (skipping BEGIN/COMMIT), and improves error reporting by consistently attaching migration context via TxError.
Changes:
- Execute migrations without a surrounding transaction when
PlannedMigration.DisableTransactionis set. - Wrap statement execution and transaction-begin failures in
TxErrorfor better migration-id context. - Add parser/tests/docs coverage for
notransactionbehavior and its non-atomic implications.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sqlparse/sqlparse_test.go | Adds tests ensuring notransaction is parsed correctly for Up vs Down sections. |
| README.md | Documents notransaction semantics, limitations, and interaction with statement blocks. |
| migrate.go | Implements non-transactional execution path and centralizes execution/recording in runMigration. |
| migrate_test.go | Adds integration tests verifying non-transactional behavior (no rollback) and tracking-table recording. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sesposito
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses some niggles we face in Satori migrations (eg. running CREATE INDEX CONCURRENTLY).
The
PlannedMigration.DisableTransactionflag was already parsed and available, this PR branches on it by running their statements directly through the connection.Also, statement/begin errors returned a bare error with no migration context. This wraps every failure in the existing
TxError, carrying the migration id.