Add telemetry file access to TestContext#985
Draft
runesoerensen wants to merge 2 commits intomainfrom
Draft
Conversation
runesoerensen
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
libcnbtracefeature is enabled, buildpacks output OpenTelemetry JSONL trace data to/tmp/libcnb-telemetry/during builds. Previously, testing this telemetry required a workaround: a secondary bash buildpack (tracing-reader) that wouldcatthe telemetry files to stdout during the build phase.This draft PR explores an alternative approach to improve that: It mounts a temporary host directory to
/tmp/libcnb-telemetry:rwviapack build --volume, reads the.jsonlfiles after the build completes, and exposes them throughdetect_telemetry()andbuild_telemetry()methods onTestContext.Also see #983 for more details