ci: close the preflight parity gap for ll-identity-selftest - #2867
Closed
gertybotbot wants to merge 1 commit into
Closed
ci: close the preflight parity gap for ll-identity-selftest#2867gertybotbot wants to merge 1 commit into
gertybotbot wants to merge 1 commit into
Conversation
`make ll-identity-selftest` is an unconditional step in ci.yml but was absent from CI_REQUIRED_CHECKS and from the dispatcher's fallback lane, so `make ci-preflight` never executed it. A change to scripts/ll-byte-identity.sh passed local preflight and only failed in CI -- the exact drift the parity self-test exists to prevent. The step also sits outside every CI-PARITY-STEPS marker block, so the parity checker could not see the omission either. Wire it in properly rather than exempt it: the target runs scripts/ll-identity-selftest.sh against synthetic .ll snippets, needs no compiler build, and completes in ~0.1s, so it costs local preflight nothing. - CI_REQUIRED_CHECKS: add the ll-identity-selftest entry - fallback lane: add_command "make ll-identity-selftest" + 15s estimate - corpus-floors.tsv: ci-required-checks 32 -> 33, in this same commit as the floor's own failure message instructs Also document the one remaining genuine exemption. `make licenses-check` (ci.yml) is likewise unconditional, outside the markers, and absent from CI_REQUIRED_CHECKS -- but there it is the right call, because it needs cargo-about at a pinned version, installed by the step immediately above. Record that rationale inline following the existing leak-scan convention, so the next person auditing this does not have to re-derive it. The other six unconditional out-of-marker `run: make` steps are already covered via `make lint` or an existing add_command, so the residual after this commit is zero. Verification: check-preflight-ci-parity.sh 33/33 and 28/28 (rc=0), preflight-parity-selftest.sh 5/5, ll-identity-selftest.sh 6/6, check-corpus-floors.sh 21/21, ci.yml parses, dispatcher passes bash -n. Closes hew-lang#2860
This was referenced Aug 8, 2026
Contributor
Author
|
Closing as superseded — the fix landed independently in Found while rebasing this branch onto
Nothing here is worth carrying forward, so this needs no review time. Reopen if the timeout floor is wanted as a standalone one-liner. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make ll-identity-selftestis an unconditional step in ci.yml but was absentfrom CI_REQUIRED_CHECKS and from the dispatcher's fallback lane, so
make ci-preflightnever executed it. A change to scripts/ll-byte-identity.shpassed local preflight and only failed in CI -- the exact drift the parity
self-test exists to prevent. The step also sits outside every CI-PARITY-STEPS
marker block, so the parity checker could not see the omission either.
Wire it in properly rather than exempt it: the target runs
scripts/ll-identity-selftest.sh against synthetic .ll snippets, needs no
compiler build, and completes in ~0.1s, so it costs local preflight nothing.
floor's own failure message instructs
Also document the one remaining genuine exemption.
make licenses-check(ci.yml) is likewise unconditional, outside the markers, and absent from
CI_REQUIRED_CHECKS -- but there it is the right call, because it needs
cargo-about at a pinned version, installed by the step immediately above.
Record that rationale inline following the existing leak-scan convention, so
the next person auditing this does not have to re-derive it.
The other six unconditional out-of-marker
run: makesteps are alreadycovered via
make lintor an existing add_command, so the residual afterthis commit is zero.
Verification: check-preflight-ci-parity.sh 33/33 and 28/28 (rc=0),
preflight-parity-selftest.sh 5/5, ll-identity-selftest.sh 6/6,
check-corpus-floors.sh 21/21, ci.yml parses, dispatcher passes bash -n.
Closes #2860